From b2e92bfd9f25274277f15faa6e9a70a7d0a36dfe Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Thu, 25 Apr 2019 18:54:43 +0900 Subject: [PATCH] Resurrect `make xxx-github PR=1234` interface `call xxx, yyy` seems to pass " yyy" instead of "yyy". --- defs/gmake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/defs/gmake.mk b/defs/gmake.mk index 213eb33f1e..e2e4a3ba39 100644 --- a/defs/gmake.mk +++ b/defs/gmake.mk @@ -161,7 +161,7 @@ REMOTE_GUTHUB_URL = $(shell git -C "$(srcdir)" config remote.github.url) .PHONY: fetch-github fetch-github: - $(call fetch-github, $(PR)) + $(call fetch-github,$(PR)) define fetch-github $(if $(1),,\ @@ -183,7 +183,7 @@ checkout-github: fetch-github .PHONY: merge-github merge-github: fetch-github - $(call merge-github, $(PR)) + $(call merge-github,$(PR)) define merge-github $(eval GITHUB_MERGE_BASE := $(shell git -C "$(srcdir)" log -1 --format=format:%H))