diff --git a/ChangeLog b/ChangeLog index c98583119b..df5c086975 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Sun Feb 12 16:38:13 2012 Akinori MUSHA + + * lib/shellwords.rb (Shellwords#shellescape): Drop the //n flag + that only causes warnings with no real effect. [Bug #5637] + Sun Feb 12 16:34:55 2012 Akinori MUSHA * tool/merger.rb (#default_merge_branch): Add support for diff --git a/lib/shellwords.rb b/lib/shellwords.rb index f1300612bb..6f31a38ee2 100644 --- a/lib/shellwords.rb +++ b/lib/shellwords.rb @@ -69,15 +69,21 @@ module Shellwords # # ... # } # + # It is caller's responsibility to encode the string in the right + # encoding for the shell environment where this string is used. + # Multibyte characters are treated as multibyte characters, not + # bytes. + # def shellescape(str) # An empty argument will be skipped, so return empty quotes. return "''" if str.empty? str = str.dup - # Process as a single byte sequence because not all shell - # implementations are multibyte aware. - str.gsub!(/([^A-Za-z0-9_\-.,:\/@\n])/n, "\\\\\\1") + # Treat multibyte characters as is. It is caller's responsibility + # to encode the string in the right encoding for the shell + # environment. + str.gsub!(/([^A-Za-z0-9_\-.,:\/@\n])/, "\\\\\\1") # A LF cannot be escaped with a backslash because a backslash + LF # combo is regarded as line continuation and simply ignored. diff --git a/test/test_shellwords.rb b/test/test_shellwords.rb index d48a8882c8..593f0e0aea 100644 --- a/test/test_shellwords.rb +++ b/test/test_shellwords.rb @@ -1,3 +1,4 @@ +# -*- coding: utf-8 -*- require 'test/unit' require 'shellwords' @@ -36,4 +37,11 @@ class TestShellwords < Test::Unit::TestCase shellwords(bad_cmd) end end + + def test_multibyte_characters + # This is not a spec. It describes the current behavior which may + # be changed in future. There would be no multibyte character + # used as shell meta-character that needs to be escaped. + assert_equal "\\あ\\い", "あい".shellescape + end end diff --git a/version.h b/version.h index da38881180..640b45c61f 100644 --- a/version.h +++ b/version.h @@ -1,5 +1,5 @@ #define RUBY_VERSION "1.9.3" -#define RUBY_PATCHLEVEL 98 +#define RUBY_PATCHLEVEL 99 #define RUBY_RELEASE_DATE "2012-02-12" #define RUBY_RELEASE_YEAR 2012