kotovalexarian-likes-github
/
ruby--ruby
mirror of https://github.com/ruby/ruby.git
1
0
Fork 0
Code Releases Activity

rb_provide_feature: Prevent $LOADED_FEATURES from being copied 

[Bug #18599]

`vm->loaded_features` and `vm->loaded_features_snapshot` both share the
same root. When a feature is pushed into `loaded_features`, the sharing
is broken and `loaded_features` is copied.

So an application requiring 1000 files, will allocate 1000 arrays of
increasing size, which is very wasteful.

To avoid this, we first clear the snapshot, so that `loaded_features`
can directly be pushed into.

Co-Authored-By: Peter Zhu <peter.zhu@shopify.com>
This commit is contained in:
Jean Boussier 2022-02-23 16:51:28 +01:00
parent 651b2e5959
commit b8f0dc59d5
Notes: git 2022-02-24 02:29:45 +09:00 
Merged: https://github.com/ruby/ruby/pull/5593
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
load.c
View File

@ -657,6 +657,10 @@ rb_provide_feature(rb_vm_t *vm, VALUE feature)
rb_str_freeze(feature);
get_loaded_features_index(vm);
// If loaded_features and loaded_features_snapshot share the same backing
// array, pushing into it would cause the whole array to be copied.
// To avoid this we first clear loaded_features_snapshot.
rb_ary_clear(vm->loaded_features_snapshot);
rb_ary_push(features, rb_fstring(feature));
features_index_add(vm, feature, INT2FIX(RARRAY_LEN(features)-1));
reset_loaded_features_snapshot(vm);