kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Add setglobal to yjit

Browse source 
Adds yjit support for setting global variables.

Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org>
Co-authored-by: John Hawthorn <john@hawthorn.email>
This commit is contained in:
eileencodes 2021-07-27 14:57:30 -04:00 • committed by Alan Wu
parent dd23e4658b
commit b91078ea74
3 changed files with 36 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
bootstraptest/test_yjit.rb
View file

@ -1,5 +1,13 @@
# Check that global variables work
# Check that global variable set works
assert_equal 'string', %q{
def foo
$foo = "string"
end
foo
}
# Check that global variables work
assert_equal 'string', %q{
$foo = "string"

4
test/ruby/test_yjit.rb
View file

@ -55,6 +55,10 @@ class TestYJIT < Test::Unit::TestCase
assert_compiles('-"foo" == -"bar"', insns: %i[opt_eq], result: false)
end
def test_compile_set_and_get_global
assert_compiles('$foo = 123; $foo', insns: %i[setglobal], result: 123)
end
def test_getlocal_with_level
assert_compiles(<<~RUBY, insns: %i[getlocal opt_plus], result: [[7]])
def foo(foo, bar)

23
yjit_codegen.c
View file

@ -3447,6 +3447,28 @@ gen_getglobal(jitstate_t* jit, ctx_t* ctx)
return YJIT_KEEP_COMPILING;
}
static codegen_status_t
gen_setglobal(jitstate_t* jit, ctx_t* ctx)
{
ID gid = jit_get_arg(jit, 0);
// Save YJIT registers
yjit_save_regs(cb);
mov(cb, C_ARG_REGS[0], imm_opnd(gid));
x86opnd_t val = ctx_stack_pop(ctx, 1);
mov(cb, C_ARG_REGS[1], val);
call_ptr(cb, REG0, (void *)&rb_gvar_set);
// Load YJIT registers
yjit_load_regs(cb);
return YJIT_KEEP_COMPILING;
}
static codegen_status_t
gen_opt_getinlinecache(jitstate_t *jit, ctx_t *ctx)
{
@ -3690,6 +3712,7 @@ yjit_init_codegen(void)
yjit_reg_op(BIN(send), gen_send);
yjit_reg_op(BIN(leave), gen_leave);
yjit_reg_op(BIN(getglobal), gen_getglobal);
yjit_reg_op(BIN(setglobal), gen_setglobal);
yjit_method_codegen_table = st_init_numtable();