kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* test/ruby/test_thread.rb

Browse source 
(TestThreadGroup#test_thread_timer_and_interrupt): skip exit status
  assertion because we cannot get signal status on Windows.

* win32/win32.c (CreateChild): create process group to receive the
  signal by GenerateConsoleCtrlEvent().

* win32/win32.c (kill): use CTRL_BREAK_EVENT instead of CTRL_C_EVENT
  if a process group is specified. CTRL_C_EVENT signal cannot be
  generated for process groups for the specification.
  [ruby-dev:45149] [Bug #5812]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34389 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
shirosaki 2012-01-28 00:51:40 +00:00
parent 494fd237f0
commit bb65920642
3 changed files with 30 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ChangeLog
View file

@ -1,3 +1,17 @@
Sat Jan 28 08:18:11 2012 Hiroshi Shirosaki <h.shirosaki@gmail.com>
* test/ruby/test_thread.rb
(TestThreadGroup#test_thread_timer_and_interrupt): skip exit status
assertion because we cannot get signal status on Windows.
* win32/win32.c (CreateChild): create process group to receive the
signal by GenerateConsoleCtrlEvent().
* win32/win32.c (kill): use CTRL_BREAK_EVENT instead of CTRL_C_EVENT
if a process group is specified. CTRL_C_EVENT signal cannot be
generated for process groups for the specification.
[ruby-dev:45149] [Bug #5812]
Sat Jan 28 07:46:03 2012 Hiroshi Shirosaki <h.shirosaki@gmail.com> Sat Jan 28 07:46:03 2012 Hiroshi Shirosaki <h.shirosaki@gmail.com>
* thread_win32.c (rb_w32_wait_events_blocking): use * thread_win32.c (rb_w32_wait_events_blocking): use

5
test/ruby/test_thread.rb
View file

@ -694,9 +694,14 @@ class TestThreadGroup < Test::Unit::TestCase
Process.kill(:SIGINT, pid) Process.kill(:SIGINT, pid)
Process.wait(pid) Process.wait(pid)
s = $? s = $?
if /mswin|mingw/ =~ RUBY_PLATFORM
# status of signal is not supported on Windows
assert_equal(pid, s.pid)
else
assert_equal([false, true, false], assert_equal([false, true, false],
[s.exited?, s.signaled?, s.stopped?], [s.exited?, s.signaled?, s.stopped?],
"[s.exited?, s.signaled?, s.stopped?]") "[s.exited?, s.signaled?, s.stopped?]")
end
t1 = Time.now.to_f t1 = Time.now.to_f
assert_in_delta(t1 - t0, 1, 1) assert_in_delta(t1 - t0, 1, 1)
end end

10
win32/win32.c
View file

@ -1132,7 +1132,7 @@ CreateChild(const WCHAR *cmd, const WCHAR *prog, SECURITY_ATTRIBUTES *psa,
aStartupInfo.hStdError = GetStdHandle(STD_ERROR_HANDLE); aStartupInfo.hStdError = GetStdHandle(STD_ERROR_HANDLE);
} }
dwCreationFlags = (NORMAL_PRIORITY_CLASS); dwCreationFlags = (CREATE_NEW_PROCESS_GROUP | NORMAL_PRIORITY_CLASS);
if (lstrlenW(cmd) > 32767) { if (lstrlenW(cmd) > 32767) {
child->pid = 0; /* release the slot */ child->pid = 0; /* release the slot */
@ -4094,7 +4094,13 @@ kill(int pid, int sig)
case SIGINT: case SIGINT:
RUBY_CRITICAL({ RUBY_CRITICAL({
if (!GenerateConsoleCtrlEvent(CTRL_C_EVENT, (DWORD)pid)) { DWORD ctrlEvent = CTRL_C_EVENT;
if (pid != 0) {
/* CTRL+C signal cannot be generated for process groups.
* Instead, we use CTRL+BREAK signal. */
ctrlEvent = CTRL_BREAK_EVENT;
}
if (!GenerateConsoleCtrlEvent(ctrlEvent, (DWORD)pid)) {
if ((err = GetLastError()) == 0) if ((err = GetLastError()) == 0)
errno = EPERM; errno = EPERM;
else else