kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Remove T_OBJECT runtime check

Browse source 
If the cached class uses the default allocator, then all instances
coming from the class should be T_OBJECT instances.  Meaning we can just
check the allocator function at compile time, then skip the runtime
T_OBJECT check
This commit is contained in:
Aaron Patterson 2020-11-12 09:25:14 -08:00 • committed by Alan Wu
parent e17053c720
commit be91995a5e
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
ujit_compile.c
View file

@ -635,6 +635,12 @@ gen_getinstancevariable(codeblock_t* cb, codeblock_t* ocb, ctx_t* ctx)
return false; return false;
} }
// If the class uses the default allocator, instances should all be T_OBJECT
if (rb_get_alloc_func(ic->entry->class_value) != rb_class_allocate_instance)
{
return false;
}
uint32_t ivar_index = ic->entry->index; uint32_t ivar_index = ic->entry->index;
// Create a size-exit to fall back to the interpreter // Create a size-exit to fall back to the interpreter
@ -664,12 +670,6 @@ gen_getinstancevariable(codeblock_t* cb, codeblock_t* ocb, ctx_t* ctx)
test(cb, flags_opnd, imm_opnd(ROBJECT_EMBED)); test(cb, flags_opnd, imm_opnd(ROBJECT_EMBED));
jnz_ptr(cb, side_exit); jnz_ptr(cb, side_exit);
// Check that this is a Ruby object (not a string, etc)
mov(cb, REG1, flags_opnd);
and(cb, REG1, imm_opnd(RUBY_T_MASK));
cmp(cb, REG1, imm_opnd(T_OBJECT));
jne_ptr(cb, side_exit);
// Get a pointer to the extended table // Get a pointer to the extended table
x86opnd_t tbl_opnd = mem_opnd(64, REG0, offsetof(struct RObject, as.heap.ivptr)); x86opnd_t tbl_opnd = mem_opnd(64, REG0, offsetof(struct RObject, as.heap.ivptr));
mov(cb, REG0, tbl_opnd); mov(cb, REG0, tbl_opnd);