mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
Warn on access/modify of $SAFE, and remove effects of modifying $SAFE
This removes the security features added by $SAFE = 1, and warns for access or modification of $SAFE from Ruby-level, as well as warning when calling all public C functions related to $SAFE. This modifies some internal functions that took a safe level argument to no longer take the argument. rb_require_safe now warns, rb_require_string has been added as a version that takes a VALUE and does not warn. One public C function that still takes a safe level argument and that this doesn't warn for is rb_eval_cmd. We may want to consider adding an alternative method that does not take a safe level argument, and warn for rb_eval_cmd.
This commit is contained in:
parent
7b6a8b5b54
commit
c5c05460ac
Notes:
git
2019-11-18 08:01:15 +09:00
59 changed files with 283 additions and 751 deletions
|
@ -558,20 +558,22 @@ describe "C-API String function" do
|
|||
end
|
||||
|
||||
describe "SafeStringValue" do
|
||||
it "raises for tained string when $SAFE is 1" do
|
||||
begin
|
||||
Thread.new {
|
||||
$SAFE = 1
|
||||
-> {
|
||||
@s.SafeStringValue("str".taint)
|
||||
}.should raise_error(SecurityError)
|
||||
}.join
|
||||
ensure
|
||||
$SAFE = 0
|
||||
ruby_version_is ''...'2.7' do
|
||||
it "raises for tained string when $SAFE is 1" do
|
||||
begin
|
||||
Thread.new {
|
||||
$SAFE = 1
|
||||
-> {
|
||||
@s.SafeStringValue("str".taint)
|
||||
}.should raise_error(SecurityError)
|
||||
}.join
|
||||
ensure
|
||||
$SAFE = 0
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
it_behaves_like :string_value_macro, :SafeStringValue
|
||||
it_behaves_like :string_value_macro, :SafeStringValue
|
||||
end
|
||||
end
|
||||
|
||||
describe "rb_str_modify_expand" do
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue