kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

missing/setproctitle.c: remove nonsense NULL check

Browse source 
If fmt is NULL, ptitle is uninitialized and used.
SETPROCTITLE(3bsd) says "If fmt is NULL, the process title is restored",
but looks like the feature is not implemented in missing/setproctitle.c.
At least the source code of ruby does not pass NULL to the function.
So I assume this function requires non-NULL fmt.

This issue was found by Coverity Scan.
This commit is contained in:
Yusuke Endoh 2019-10-12 21:10:49 +09:00
parent f405564711
commit cb14c4a535
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
missing/setproctitle.c
View file

@ -152,10 +152,9 @@ setproctitle(const char *fmt, ...)
return;
#endif
/* fmt must be non-NULL */
va_start(ap, fmt);
if (fmt != NULL) {
vsnprintf(ptitle, sizeof(ptitle) , fmt, ap);
}
vsnprintf(ptitle, sizeof(ptitle), fmt, ap);
va_end(ap);
#if SPT_TYPE == SPT_PSTAT