1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

Run nmake check on Actions (#4487)

* Run nmake check on Actions

* Skip tests not working in mswin GitHub Actions

* Override TEMP

* Revert "Skip tests not working in mswin GitHub Actions"

This reverts commit 544d2575fc.

* Revert "Revert "Skip tests not working in mswin GitHub Actions""

This reverts commit e1f8ad7862.

* Fix timeouts

* Skip some more broken tests

* Update windows.yml

* Add a guard for rbasic_spec

* Revert "Update windows.yml"

This reverts commit bc9694b6b3.

* Skip the ensure clause

* Simplify the ensure
This commit is contained in:
Takashi Kokubun 2021-05-11 15:18:44 -07:00 committed by GitHub
parent 07f055bb13
commit cc1ea6e023
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
Notes: git 2021-05-12 07:19:11 +09:00
Merged-By: k0kubun <takashikkbn@gmail.com>
9 changed files with 27 additions and 3 deletions

View file

@ -4,7 +4,7 @@ jobs:
make:
strategy:
matrix:
test_task: [test]
test_task: [check] # to make job names consistent
os: [windows-2019]
vs: [2019]
fail-fast: false
@ -62,10 +62,24 @@ jobs:
nmake extract-extlibs
nmake
- name: nmake test
timeout-minutes: 30
timeout-minutes: 5
run: |
call "%VCVARS%"
nmake ${{ matrix.test_task }}
nmake test
- name: nmake test-all
timeout-minutes: 60
run: |
call "%VCVARS%"
# %TEMP% is inconsistent with %TMP% and test-all expects they are consistent.
# https://github.com/actions/virtual-environments/issues/712#issuecomment-613004302
set TMP=%USERPROFILE%\AppData\Local\Temp
set TEMP=%USERPROFILE%\AppData\Local\Temp
nmake test-all
- name: nmake test-spec
timeout-minutes: 10
run: |
call "%VCVARS%"
nmake test-spec
- uses: k0kubun/action-slack@v2.0.0
with:
payload: |

View file

@ -1,6 +1,7 @@
require_relative 'spec_helper'
require_relative 'shared/rbasic'
load_extension("rbasic")
return if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
load_extension("data")
load_extension("array")

View file

@ -268,6 +268,7 @@ class TestResolvDNS < Test::Unit::TestCase
end
def test_no_server
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
u = UDPSocket.new
u.bind("127.0.0.1", 0)
_, port, _, host = u.addr

View file

@ -1257,6 +1257,7 @@ class TestFileExhaustive < Test::Unit::TestCase
assert_equal(regular_file, File.dirname(regular_file, 0))
assert_equal(@dir, File.dirname(regular_file, 1))
assert_equal(File.dirname(@dir), File.dirname(regular_file, 2))
return if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # rootdir and tmpdir are in different drives
assert_equal(rootdir, File.dirname(regular_file, regular_file.count('/')))
assert_raise(ArgumentError) {File.dirname(regular_file, -1)}
end

View file

@ -106,6 +106,7 @@ install:
end
def test_build_extensions
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
@spec.extensions << 'ext/extconf.rb'
ext_dir = File.join @spec.gem_dir, 'ext'
@ -141,6 +142,7 @@ install:
end
def test_build_extensions_with_gemhome_with_space
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
new_gemhome = File.join @tempdir, 'gem home'
File.rename(@gemhome, new_gemhome)
@gemhome = new_gemhome
@ -161,6 +163,7 @@ install:
false
end
end
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
@spec.extensions << 'ext/extconf.rb'

View file

@ -1482,6 +1482,7 @@ gem 'other', version
def test_install_extension_and_script
skip "Makefile creation crashes on jruby" if Gem.java_platform?
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
@spec = setup_base_spec
@spec.extensions << "extconf.rb"

View file

@ -63,6 +63,7 @@ class TestGemResolverGitSpecification < Gem::TestCase
def test_install_extension
skip if Gem.java_platform?
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
name, _, repository, = git_gem 'a', 1 do |s|
s.extensions << 'ext/extconf.rb'
end

View file

@ -247,6 +247,7 @@ class WEBrick::TestFileHandler < Test::Unit::TestCase
def test_short_filename
return if File.executable?(__FILE__) # skip on strange file system
return if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
config = {
:CGIInterpreter => TestWEBrick::RubyBin,

View file

@ -323,6 +323,7 @@ class TestWEBrickHTTPProxy < Test::Unit::TestCase
end if defined?(OpenSSL::SSL)
def test_upstream_proxy
return if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
# Testing GET or POST through the upstream proxy server
# Note that the upstream proxy server works as the origin server.
# +------+