From ccad34f4533ffe532fea796def06808dc5a85877 Mon Sep 17 00:00:00 2001 From: Kazuhiro NISHIYAMA Date: Wed, 4 Sep 2019 12:51:39 +0900 Subject: [PATCH] Add TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest --- .github/workflows/macos.yml | 3 ++- .github/workflows/ubuntu.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index a2ef459cb4..21804ab0be 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -47,7 +47,8 @@ jobs: if: matrix.test_task != 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') # test-bundled-gems is separated for marking `continue-on-error` because it randomly fails. - name: Tests - run: make -s ${{ matrix.test_task }} TESTOPTS="$JOBS -q --tty=no" + # Remove TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest if https://github.com/seattlerb/minitest/pull/798 resolved + run: make -s ${{ matrix.test_task }} TESTOPTS="$JOBS -q --tty=no" TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest continue-on-error: true if: matrix.test_task == 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') - name: Leaked Globals diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 69d2524e98..26d439840e 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -50,7 +50,8 @@ jobs: if: matrix.test_task != 'test-bundled-gems' && !contains(github.event.head_commit.message, '[ci skip]') # test-bundled-gems is separated for marking `continue-on-error` because it randomly fails. - name: Tests (test-bundled-gems) - run: make -s ${{ matrix.test_task }} + # Remove TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest if https://github.com/seattlerb/minitest/pull/798 resolved + run: make -s ${{ matrix.test_task }} TEST_BUNDLED_GEMS_ALLOW_FAILURES=minitest env: RUBY_TESTOPTS: "-q --tty=no" continue-on-error: true