kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Make String#{strip,lstrip}{,!} strip leading NUL bytes

Browse source 
The documentation already specifies that they strip whitespace
and defines whitespace to include null.

This wraps the new behavior in the appropriate guards in the specs,
but does not specify behavior for previous versions, because this
is a bug that could be backported.

Fixes [Bug #17467]
This commit is contained in:
Jeremy Evans 2021-02-09 13:50:36 -08:00 • committed by Nobuyoshi Nakada
parent efd19badf4
commit cfd162d535
Notes: git 2021-02-20 11:18:14 +09:00
4 changed files with 40 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

18
spec/ruby/core/string/lstrip_spec.rb
View file

@ -7,11 +7,13 @@ describe "String#lstrip" do
" hello world ".lstrip.should == "hello world "
"\n\r\t\n\v\r hello world ".lstrip.should == "hello world "
"hello".lstrip.should == "hello"
"\000 \000hello\000 \000".lstrip.should == "\000 \000hello\000 \000"
end
it "does not strip leading \\0" do
"\x00hello".lstrip.should == "\x00hello"
ruby_version_is '3.1' do
it "strips leading \\0" do
"\x00hello".lstrip.should == "hello"
"\000 \000hello\000 \000".lstrip.should == "hello\000 \000"
end
end
ruby_version_is ''...'2.7' do
@ -28,10 +30,14 @@ describe "String#lstrip!" do
a = " hello "
a.lstrip!.should equal(a)
a.should == "hello "
end
a = "\000 \000hello\000 \000"
a.lstrip!
a.should == "\000 \000hello\000 \000"
ruby_version_is '3.1' do
it "strips leading \\0" do
a = "\000 \000hello\000 \000"
a.lstrip!
a.should == "hello\000 \000"
end
end
it "returns nil if no modifications were made" do