kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Make String#{strip,lstrip}{,!} strip leading NUL bytes

Browse source 
The documentation already specifies that they strip whitespace
and defines whitespace to include null.

This wraps the new behavior in the appropriate guards in the specs,
but does not specify behavior for previous versions, because this
is a bug that could be backported.

Fixes [Bug #17467]
This commit is contained in:
Jeremy Evans 2021-02-09 13:50:36 -08:00 • committed by Nobuyoshi Nakada
parent efd19badf4
commit cfd162d535
Notes: git 2021-02-20 11:18:14 +09:00
4 changed files with 40 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

22
spec/ruby/core/string/strip_spec.rb
View file

@ -6,11 +6,12 @@ describe "String#strip" do
" hello ".strip.should == "hello"
" hello world ".strip.should == "hello world"
"\tgoodbye\r\v\n".strip.should == "goodbye"
"\x00 goodbye \x00".strip.should == "\x00 goodbye"
end
it "returns a copy of self with trailing NULL bytes and whitespace" do
" \x00 goodbye \x00 ".strip.should == "\x00 goodbye"
ruby_version_is '3.1' do
it "returns a copy of self without leading and trailing NULL bytes and whitespace" do
" \x00 goodbye \x00 ".strip.should == "goodbye"
end
end
ruby_version_is ''...'2.7' do
@ -31,11 +32,6 @@ describe "String#strip!" do
a = "\tgoodbye\r\v\n"
a.strip!
a.should == "goodbye"
a = "\000 goodbye \000"
a.strip!
a.should == "\000 goodbye"
end
it "returns nil if no modifications where made" do
@ -44,10 +40,12 @@ describe "String#strip!" do
a.should == "hello"
end
it "modifies self removing trailing NULL bytes and whitespace" do
a = " \x00 goodbye \x00 "
a.strip!
a.should == "\x00 goodbye"
ruby_version_is '3.1' do
it "removes leading and trailing NULL bytes and whitespace" do
a = "\000 goodbye \000"
a.strip!
a.should == "goodbye"
end
end
it "raises a FrozenError on a frozen instance that is modified" do