kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[rubygems/rubygems] Improve performance of Specification#missing_extensions?

Browse source 
90c1919f94
This commit is contained in:
Masataka Pocke Kuwabara 2021-10-03 01:30:55 +09:00 • committed by Hiroshi SHIBATA
parent ad92651d64
commit d03d122ba1
4 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/rubygems/defaults.rb
View file

@ -59,7 +59,7 @@ module Gem
# Path to specification files of default gems. # Path to specification files of default gems.
def self.default_specifications_dir def self.default_specifications_dir
File.join(Gem.default_dir, "specifications", "default") @default_specifications_dir ||= File.join(Gem.default_dir, "specifications", "default")
end end
## ##

4
lib/rubygems/specification.rb
View file

@ -1556,8 +1556,8 @@ class Gem::Specification < Gem::BasicSpecification
# the gem.build_complete file is missing. # the gem.build_complete file is missing.
def build_extensions # :nodoc: def build_extensions # :nodoc:
return if default_gem?
return if extensions.empty? return if extensions.empty?
return if default_gem?
return if File.exist? gem_build_complete_path return if File.exist? gem_build_complete_path
return if !File.writable?(base_dir) return if !File.writable?(base_dir)
return if !File.exist?(File.join(base_dir, 'extensions')) return if !File.exist?(File.join(base_dir, 'extensions'))
@ -2120,8 +2120,8 @@ class Gem::Specification < Gem::BasicSpecification
# probably want to build_extensions # probably want to build_extensions
def missing_extensions? def missing_extensions?
return false if default_gem?
return false if extensions.empty? return false if extensions.empty?
return false if default_gem?
return false if File.exist? gem_build_complete_path return false if File.exist? gem_build_complete_path
true true

5
spec/bundler/support/hax.rb
View file

@ -9,7 +9,10 @@ module Gem
Gem.ruby = ENV["RUBY"] Gem.ruby = ENV["RUBY"]
end end
@default_dir = ENV["BUNDLER_GEM_DEFAULT_DIR"] if ENV["BUNDLER_GEM_DEFAULT_DIR"] if ENV["BUNDLER_GEM_DEFAULT_DIR"]
@default_dir = ENV["BUNDLER_GEM_DEFAULT_DIR"]
@default_specifications_dir = nil
end
if ENV["BUNDLER_SPEC_PLATFORM"] if ENV["BUNDLER_SPEC_PLATFORM"]
class Platform class Platform

2
test/rubygems/helper.rb
View file

@ -396,6 +396,7 @@ class Gem::TestCase < Test::Unit::TestCase
ENV['GEM_PRIVATE_KEY_PASSPHRASE'] = PRIVATE_KEY_PASSPHRASE ENV['GEM_PRIVATE_KEY_PASSPHRASE'] = PRIVATE_KEY_PASSPHRASE
Gem.instance_variable_set(:@default_specifications_dir, nil)
if Gem.java_platform? if Gem.java_platform?
@orig_default_gem_home = RbConfig::CONFIG['default_gem_home'] @orig_default_gem_home = RbConfig::CONFIG['default_gem_home']
RbConfig::CONFIG['default_gem_home'] = @gemhome RbConfig::CONFIG['default_gem_home'] = @gemhome
@ -479,6 +480,7 @@ class Gem::TestCase < Test::Unit::TestCase
RbConfig::CONFIG['bindir'] = @orig_bindir RbConfig::CONFIG['bindir'] = @orig_bindir
Gem.instance_variable_set :@default_specifications_dir, nil
if Gem.java_platform? if Gem.java_platform?
RbConfig::CONFIG['default_gem_home'] = @orig_default_gem_home RbConfig::CONFIG['default_gem_home'] = @orig_default_gem_home
else else