kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Relax MJIT_BUILD_DIR restriction

Browse source 
* mjit.c (init_header_filename): sticky-mode directory probably
  would be less unsafe even if it is not owned.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65551 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nobu 2018-11-05 17:27:10 +00:00
parent 62ebf35592
commit d05e04b825
1 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
mjit.c
View file

@ -394,15 +394,20 @@ init_header_filename(void)
/* This path is not intended to be used on production, but using build directory's /* This path is not intended to be used on production, but using build directory's
header file here because people want to run `make test-all` without running header file here because people want to run `make test-all` without running
`make install`. Don't use $MJIT_SEARCH_BUILD_DIR except for test-all. */ `make install`. Don't use $MJIT_SEARCH_BUILD_DIR except for test-all. */
if (build_dir[0] != '/' || if (build_dir[0] != '/') {
stat(build_dir, &st) || !S_ISDIR(st.st_mode) || verbose(1, "Non-absolute path MJIT_BUILD_DIR: %s", build_dir);
st.st_uid != getuid() || (st.st_mode & 022) || }
!rb_path_check(build_dir)) { else if (stat(build_dir, &st) || !S_ISDIR(st.st_mode)) {
verbose(1, "Non-directory path MJIT_BUILD_DIR: %s", build_dir);
}
else if (!rb_path_check(build_dir)) {
verbose(1, "Unsafe MJIT_BUILD_DIR: %s", build_dir); verbose(1, "Unsafe MJIT_BUILD_DIR: %s", build_dir);
return FALSE; return FALSE;
} }
basedir = build_dir; else {
baselen = sizeof(build_dir) - 1; basedir = build_dir;
baselen = sizeof(build_dir) - 1;
}
} }
#endif #endif