diff --git a/ChangeLog b/ChangeLog index e97020c53d..7c9e7a93a8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Wed Apr 22 12:20:13 2009 Nobuyoshi Nakada + + * eval.c (proc_invoke): shares dmethod scope local variables. + a patch from coderrr at [ruby-core:23050] + + * gc.c (obj_free): do not free cloned scope local variables. + Tue Apr 21 09:20:21 2009 Nobuyoshi Nakada * lib/mkmf.rb (init_mkmf): needs default library path even if diff --git a/eval.c b/eval.c index 9ab9880372..e1f534d0c0 100644 --- a/eval.c +++ b/eval.c @@ -8942,7 +8942,7 @@ proc_invoke(proc, args, self, klass) OBJSETUP(scope, tmp, T_SCOPE); scope->local_tbl = _block.scope->local_tbl; scope->local_vars = _block.scope->local_vars; - scope->flags |= SCOPE_CLONE; + scope->flags |= SCOPE_CLONE | (_block.scope->flags & SCOPE_MALLOC); _block.scope = scope; } /* modify current frame */ diff --git a/gc.c b/gc.c index 1dc5983811..322982264c 100644 --- a/gc.c +++ b/gc.c @@ -1380,7 +1380,7 @@ obj_free(obj) VALUE *vars = RANY(obj)->as.scope.local_vars-1; if (!(RANY(obj)->as.scope.flags & SCOPE_CLONE) && vars[0] == 0) RUBY_CRITICAL(free(RANY(obj)->as.scope.local_tbl)); - if (RANY(obj)->as.scope.flags & SCOPE_MALLOC) + if ((RANY(obj)->as.scope.flags & (SCOPE_MALLOC|SCOPE_CLONE)) == SCOPE_MALLOC) RUBY_CRITICAL(free(vars)); } break; diff --git a/test/ruby/test_proc.rb b/test/ruby/test_proc.rb index 0ddc76a804..5436879041 100644 --- a/test/ruby/test_proc.rb +++ b/test/ruby/test_proc.rb @@ -91,4 +91,14 @@ class TestProc < Test::Unit::TestCase assert_equal(10, Proc.new{|&b| b.call(10)}.call {|x| x}) assert_equal(12, Proc.new{|a,&b| b.call(a)}.call(12) {|x| x}) end + + def test_define_method_scope + a = 1 + c = Class.new + c.send(:define_method, :x) do |*| + lambda {a = 2}.call + end + c.new.x(nil) + assert_equal(2, a, '[ruby-core:23050]') + end end diff --git a/version.h b/version.h index c6416878df..a585def43b 100644 --- a/version.h +++ b/version.h @@ -1,7 +1,7 @@ #define RUBY_VERSION "1.8.8" -#define RUBY_RELEASE_DATE "2009-04-21" +#define RUBY_RELEASE_DATE "2009-04-22" #define RUBY_VERSION_CODE 188 -#define RUBY_RELEASE_CODE 20090421 +#define RUBY_RELEASE_CODE 20090422 #define RUBY_PATCHLEVEL -1 #define RUBY_VERSION_MAJOR 1 @@ -9,7 +9,7 @@ #define RUBY_VERSION_TEENY 8 #define RUBY_RELEASE_YEAR 2009 #define RUBY_RELEASE_MONTH 4 -#define RUBY_RELEASE_DAY 21 +#define RUBY_RELEASE_DAY 22 #ifdef RUBY_EXTERN RUBY_EXTERN const char ruby_version[];