kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* compar.c (cmp_equal): warn for this release and still rescue

Browse source 
standard exceptions for a nicer transition. See #7688.
  Partly reverts r44502.
* test/ruby/test_comparable.rb: adapt assertion to match new behavior.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44646 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
eregon 2014-01-18 21:40:58 +00:00
parent 35bf7276d9
commit d1d7f12c89
3 changed files with 39 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/ruby/test_comparable.rb
View file

@ -1,4 +1,5 @@
require 'test/unit'
require_relative 'envutil'
class TestComparable < Test::Unit::TestCase
def setup
@ -20,8 +21,9 @@ class TestComparable < Test::Unit::TestCase
cmp->(x) do raise NotImplementedError, "Not a RuntimeError" end
assert_raise(NotImplementedError) { @o == nil }
bug7688 = '[ruby-core:51389] [Bug #7688]'
cmp->(x) do raise StandardError, "Even a standard error should not be rescued"; end
assert_raise(StandardError, bug7688) { @o == nil }
cmp->(x) do raise StandardError, "A standard error should be rescued"; end
warn = /Comparable#== will no more rescue exceptions .+ in the next release/
assert_warn(warn, bug7688) { @o == nil }
end
def test_gt