kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

compile.c: order with splatting

Browse source 
* compile.c (setup_args): duplicate splatting array if more
  arguments present to obey left-to-right execution order.
  [ruby-core:77701] [Bug# 12860]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56469 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nobu 2016-10-22 00:52:59 +00:00
parent e1ff9d68ab
commit d506a3521c
3 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog
View file

@ -1,3 +1,9 @@
Sat Oct 22 09:52:57 2016 Nobuyoshi Nakada <nobu@ruby-lang.org>
* compile.c (setup_args): duplicate splatting array if more
arguments present to obey left-to-right execution order.
[ruby-core:77701] [Bug# 12860]
Fri Oct 21 16:44:44 2016 Nobuyoshi Nakada <nobu@ruby-lang.org> Fri Oct 21 16:44:44 2016 Nobuyoshi Nakada <nobu@ruby-lang.org>
* dir.c (do_opendir): retry after GC when the limit for open file * dir.c (do_opendir): retry after GC when the limit for open file

4
compile.c
View file

@ -3741,7 +3741,7 @@ setup_args(rb_iseq_t *iseq, LINK_ANCHOR *args, NODE *argn, unsigned int *flag, s
switch (nd_type(argn)) { switch (nd_type(argn)) {
case NODE_SPLAT: { case NODE_SPLAT: {
COMPILE(args, "args (splat)", argn->nd_head); COMPILE(args, "args (splat)", argn->nd_head);
ADD_INSN1(args, nd_line(argn), splatarray, Qfalse); ADD_INSN1(args, nd_line(argn), splatarray, nsplat ? Qtrue : Qfalse);
argc = INT2FIX(1); argc = INT2FIX(1);
nsplat++; nsplat++;
*flag |= VM_CALL_ARGS_SPLAT; *flag |= VM_CALL_ARGS_SPLAT;
@ -3755,7 +3755,7 @@ setup_args(rb_iseq_t *iseq, LINK_ANCHOR *args, NODE *argn, unsigned int *flag, s
INIT_ANCHOR(tmp); INIT_ANCHOR(tmp);
COMPILE(tmp, "args (cat: splat)", argn->nd_body); COMPILE(tmp, "args (cat: splat)", argn->nd_body);
if (nd_type(argn) == NODE_ARGSCAT) { if (nd_type(argn) == NODE_ARGSCAT) {
ADD_INSN1(tmp, nd_line(argn), splatarray, Qfalse); ADD_INSN1(tmp, nd_line(argn), splatarray, nsplat ? Qtrue : Qfalse);
} }
else { else {
ADD_INSN1(tmp, nd_line(argn), newarray, INT2FIX(1)); ADD_INSN1(tmp, nd_line(argn), newarray, INT2FIX(1));

8
test/ruby/test_call.rb
View file

@ -90,4 +90,12 @@ class TestCall < Test::Unit::TestCase
h[:foo] = nil h[:foo] = nil
} }
end end
def test_call_splat_order
bug12860 = '[ruby-core:77701] [Bug# 12860]'
ary = [1, 2]
assert_equal([1, 2, 1], aaa(*ary, ary.shift), bug12860)
ary = [1, 2]
assert_equal([0, 1, 2, 1], aaa(0, *ary, ary.shift), bug12860)
end
end end