kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* numeric.c (rb_num2ulong_internal): Don't cast a negative double value

Browse source 
into unsigned long, which is undefined behavior.
  (rb_num2ull): Don't cast a value bigger than LLONG_MAX into
  long long, which is undefined behavior.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@40037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
akr 2013-04-01 12:14:30 +00:00
parent 0cbe2f4902
commit d6daffbbf0
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ChangeLog
View file

@ -1,3 +1,10 @@
Mon Apr 1 21:10:56 2013 Tanaka Akira <akr@fsij.org>
* numeric.c (rb_num2ulong_internal): Don't cast a negative double value
into unsigned long, which is undefined behavior.
(rb_num2ull): Don't cast a value bigger than LLONG_MAX into
long long, which is undefined behavior.
Mon Apr 1 20:57:57 2013 Tanaka Akira <akr@fsij.org>
* ext/-test-/num2int/num2int.c: Return string for result, instead of

6
numeric.c
View file

@ -2001,7 +2001,9 @@ rb_num2ulong_internal(VALUE val, int *wrap_p)
double d = RFLOAT_VALUE(val);
if (wrap_p)
*wrap_p = d <= -1.0; /* NUM2ULONG(v) uses v.to_int conceptually. */
return (unsigned long)d;
if (0 <= d)
return (unsigned long)d;
return (unsigned long)(long)d;
}
else {
char buf[24];
@ -2273,6 +2275,8 @@ rb_num2ull(VALUE val)
case T_FLOAT:
if (RFLOAT_VALUE(val) < ULLONG_MAX_PLUS_ONE
&& LLONG_MIN_MINUS_ONE_IS_LESS_THAN(RFLOAT_VALUE(val))) {
if (0 <= RFLOAT_VALUE(val))
return (unsigned LONG_LONG)(RFLOAT_VALUE(val));
return (unsigned LONG_LONG)(LONG_LONG)(RFLOAT_VALUE(val));
}
else {