kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[rubygems/rubygems] Use shellsplit instead of array of strings

Browse source 
Previously, the command string to be used for the shell command
was first generated and then split using shellsplit. This change
reverts the current behavior as it breaks if the value of remote
contains a space.

https://github.com/rubygems/rubygems/commit/6649ee10b0
This commit is contained in:
Nicholas Lee 2021-11-08 15:52:49 -08:00 • committed by git
parent e014c9d607
commit d7432fdee5
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/bundler/gem_helper.rb
View file

@ -129,8 +129,8 @@ module Bundler
def git_push(remote = nil)
remote ||= default_remote
sh(%W[git push #{remote} refs/heads/#{current_branch}])
sh(%W[git push #{remote} refs/tags/#{version_tag}])
sh("git push #{remote} refs/heads/#{current_branch}".shellsplit)
sh("git push #{remote} refs/tags/#{version_tag}".shellsplit)
Bundler.ui.confirm "Pushed git commits and release tag."
end