From da7c77152d8a0021866b671fcce1113dece1e440 Mon Sep 17 00:00:00 2001 From: headius Date: Tue, 15 Dec 2015 22:58:25 +0000 Subject: [PATCH] Remove this test, since it won't reliably pass. At the point where q.size == 0, we can't know that num_threads threads have actually finished. On e.g. JRuby, they may have called pop but not yet exited the Thread's body. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- test/thread/test_queue.rb | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/thread/test_queue.rb b/test/thread/test_queue.rb index 7ab6d1e01e..0a1ae48387 100644 --- a/test/thread/test_queue.rb +++ b/test/thread/test_queue.rb @@ -307,10 +307,7 @@ class TestQueue < Test::Unit::TestCase # wait until queue empty (Thread.pass; sleep 0.01) until q.size == 0 - # now there should be some waiting consumers - assert_equal num_threads - num_items, threads.count{|thr| thr.status} - - # tell them all to go away + # close the queue so remaining threads will wake up q.close # wait for them to go away