kotovalexarian-likes-github
/
ruby--ruby
mirror of https://github.com/ruby/ruby.git
1
0
Fork 0
Code Releases Activity

mjit.c: don't use mutex before checking availability 

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65572 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
k0kubun 2018-11-06 08:01:28 +00:00
parent 6c2014768e
commit dbd90b2dff
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
mjit.c
View File

@ -26,16 +26,18 @@ mjit_copy_job_handler(void *data)
{
struct mjit_copy_job *job = data;
int finish_p;
if (stop_worker_p) {
/* `copy_cache_from_main_thread()` stops to wait for this job. Then job data which is
allocated by `alloca()` could be expired and we might not be able to access that.
Also this should be checked before CRITICAL_SECTION_START to ensure that mutex is alive. */
return;
}
CRITICAL_SECTION_START(3, "in mjit_copy_job_handler");
finish_p = job->finish_p;
CRITICAL_SECTION_FINISH(3, "in mjit_copy_job_handler");
if (stop_worker_p || finish_p) {
/* `stop_worker_p`: `copy_cache_from_main_thread()` stops to wait for this job.
Then job data which is allocated by `alloca()` could be expired and we might
not be able to access that.
`finish_p`: make sure that this job is never executed while job is being modified. */
return;
if (finish_p) {
return; /* make sure that this job is never executed while job is being modified. */
}
if (job->cc_entries) {