kotovalexarian-likes-github
/
ruby--ruby
mirror of https://github.com/ruby/ruby.git
1
0
Fork 0
Code Releases Activity

Handle failure of opening a null device 

This issue is detected by Coverity Scan.
This commit is contained in:
Takashi Kokubun 2019-07-15 10:38:59 +09:00
parent a191009a26
commit dd4f128ac5
No known key found for this signature in database
GPG Key ID: 6FFC433B12EE23DD
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mjit_worker.c
View File

@ -548,6 +548,13 @@ COMPILER_WARNING_IGNORED(-Wdeprecated-declarations)
static pid_t static pid_t
start_process(const char *abspath, char *const *argv) start_process(const char *abspath, char *const *argv)
{ {
// Not calling non-async-signal-safe functions between vfork
// and execv for safety
int dev_null = rb_cloexec_open(ruby_null_device, O_WRONLY, 0);
if (dev_null < 0) {
verbose(1, "MJIT: Failed to open a null device: %s", strerror(errno));
return -1;
}
if (mjit_opts.verbose >= 2) { if (mjit_opts.verbose >= 2) {
const char *arg; const char *arg;
fprintf(stderr, "Starting process: %s", abspath); fprintf(stderr, "Starting process: %s", abspath);
@ -556,9 +563,6 @@ start_process(const char *abspath, char *const *argv)
fprintf(stderr, "\n"); fprintf(stderr, "\n");
} }
// Not calling non-async-signal-safe functions between vfork
// and execv for safety
int dev_null = rb_cloexec_open(ruby_null_device, O_WRONLY, 0);
pid_t pid; pid_t pid;
#ifdef _WIN32 #ifdef _WIN32
extern HANDLE rb_w32_start_process(const char *abspath, char *const *argv, int out_fd); extern HANDLE rb_w32_start_process(const char *abspath, char *const *argv, int out_fd);