From e5ce9579ecb93316d71eacf6c16a187767f05f68 Mon Sep 17 00:00:00 2001 From: duerst Date: Tue, 23 Apr 2013 08:41:56 +0000 Subject: [PATCH] lib/rexml/document.rb, lib/rexml/element.rb, lib/rexml/formatters/pretty.rb: remove opinionated language in documentation. [Bug #8309], reported by Charles Beckmann git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@40420 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 7 +++++++ lib/rexml/document.rb | 7 ++----- lib/rexml/element.rb | 7 ++----- lib/rexml/formatters/pretty.rb | 2 +- 4 files changed, 12 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index e6171234c1..b9a89469cb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Tue Apr 23 17:40:40 2013 Martin Duerst + + * lib/rexml/document.rb, lib/rexml/element.rb, + lib/rexml/formatters/pretty.rb: remove opinionated + language in documentation. [Bug #8309], + reported by Charles Beckmann + Tue Apr 23 14:04:44 2013 Shugo Maeda * lib/net/imap.rb (getacl_response): parse the mailbox of an ACL diff --git a/lib/rexml/document.rb b/lib/rexml/document.rb index 4b73696930..1e18263dda 100644 --- a/lib/rexml/document.rb +++ b/lib/rexml/document.rb @@ -195,11 +195,8 @@ module REXML # the absolute *value* of the document -- that is, it leaves the value # and number of Text nodes in the document unchanged. # ie_hack:: - # Internet Explorer is the worst piece of crap to have ever been - # written, with the possible exception of Windows itself. Since IE is - # unable to parse proper XML, we have to provide a hack to generate XML - # that IE's limited abilities can handle. This hack inserts a space - # before the /> on empty tags. Defaults to false + # This hack inserts a space before the /> on empty tags to address + # a limitation of Internet Explorer. Defaults to false # encoding:: # Encoding name as String. Change output encoding to specified encoding # instead of encoding in XML declaration. diff --git a/lib/rexml/element.rb b/lib/rexml/element.rb index 616771fc0f..c415830c14 100644 --- a/lib/rexml/element.rb +++ b/lib/rexml/element.rb @@ -678,11 +678,8 @@ module REXML # pretty-printed in such a way that the added whitespace does not affect # the parse tree of the document # ie_hack:: - # Internet Explorer is the worst piece of crap to have ever been - # written, with the possible exception of Windows itself. Since IE is - # unable to parse proper XML, we have to provide a hack to generate XML - # that IE's limited abilities can handle. This hack inserts a space - # before the /> on empty tags. Defaults to false + # This hack inserts a space before the /> on empty tags to address + # a limitation of Internet Explorer. Defaults to false # # out = '' # doc.write( out ) #-> doc is written to the string 'out' diff --git a/lib/rexml/formatters/pretty.rb b/lib/rexml/formatters/pretty.rb index 63f726e8c3..e5ba561a58 100644 --- a/lib/rexml/formatters/pretty.rb +++ b/lib/rexml/formatters/pretty.rb @@ -24,7 +24,7 @@ module REXML # is undefined. Defaults to 2. # ie_hack:: # If true, the printer will insert whitespace before closing empty - # tags, thereby allowing Internet Explorer's feeble XML parser to + # tags, thereby allowing Internet Explorer's XML parser to # function. Defaults to false. def initialize( indentation=2, ie_hack=false ) @indentation = indentation