kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

RBIMPL_ALIGNOF: do not use constexpr

Browse source 
Was definitely a bad idea to use constexpr.  It is not ubiquitous.
This commit is contained in:
卜部昌平 2020-09-24 10:58:01 +09:00
parent 0b77a86d1e
commit e75aed7abb
Notes: git 2020-09-25 11:39:04 +09:00
1 changed files with 8 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

24
include/ruby/internal/stdalign.h
View file

@ -26,14 +26,9 @@
# include <stddef.h>
#endif
#include "ruby/internal/attr/artificial.h"
#include "ruby/internal/attr/const.h"
#include "ruby/internal/attr/constexpr.h"
#include "ruby/internal/attr/forceinline.h"
#include "ruby/internal/compiler_is.h"
#include "ruby/internal/has/attribute.h"
#include "ruby/internal/has/declspec_attribute.h"
#include "ruby/internal/has/extension.h"
#include "ruby/internal/has/feature.h"
/**
@ -95,24 +90,21 @@
#elif defined(__cplusplus)
# /* C++11 `alignof()` can be buggy. */
# /* see: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69560 */
# /* But don't worry, we can use templates and `constexpr`. */
# define RBIMPL_ALIGNOF(T) ruby::rbimpl_alignof<T>()
# /* But don't worry, we can use templates. */
# define RBIMPL_ALIGNOF(T) (static_cast<size_t>(ruby::rbimpl_alignof<T>::value))
namespace ruby {
template<typename T>
RBIMPL_ATTR_CONSTEXPR(CXX11)
RBIMPL_ATTR_ARTIFICIAL()
RBIMPL_ATTR_FORCEINLINE()
RBIMPL_ATTR_CONST()
static size_t
rbimpl_alignof()
{
struct rbimpl_alignof {
typedef struct {
char _;
T t;
} type;
return offsetof(type, t);
}
enum {
value = offsetof(type, t)
};
};
}
#elif RBIMPL_COMPILER_IS(MSVC)