1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

[rubygems/rubygems] Fix underscore version for bundler itself

Previously it wouldn't play nice with the bundler version finder.

https://github.com/rubygems/rubygems/commit/d8bb81556d
This commit is contained in:
David Rodríguez 2019-09-10 11:07:03 +02:00 committed by Hiroshi SHIBATA
parent ad638a713a
commit ea5b136155
No known key found for this signature in database
GPG key ID: F9CF13417264FAC2
2 changed files with 35 additions and 1 deletions

View file

@ -281,7 +281,7 @@ class Gem::Dependency
requirement.satisfied_by?(spec.version) && env_req.satisfied_by?(spec.version)
end.map(&:to_spec)
Gem::BundlerVersionFinder.filter!(matches) if name == "bundler".freeze
Gem::BundlerVersionFinder.filter!(matches) if name == "bundler".freeze && !requirement.specific?
if platform_only
matches.reject! do |spec|

View file

@ -375,6 +375,40 @@ class TestGem < Gem::TestCase
assert_equal %w(bundler-2.0.0), loaded_spec_names
end
def test_activate_bin_path_respects_underscore_selection_if_given
bundler_latest = util_spec 'bundler', '2.0.1' do |s|
s.executables = ['bundle']
end
bundler_previous = util_spec 'bundler', '1.17.3' do |s|
s.executables = ['bundle']
end
install_specs bundler_latest, bundler_previous
File.open("Gemfile.lock", "w") do |f|
f.write <<-L.gsub(/ {8}/, "")
GEM
remote: https://rubygems.org/
specs:
PLATFORMS
ruby
DEPENDENCIES
BUNDLED WITH
2.0.1
L
end
File.open("Gemfile", "w") { |f| f.puts('source "https://rubygems.org"') }
load Gem.activate_bin_path("bundler", "bundle", "= 1.17.3")
assert_equal %w(bundler-1.17.3), loaded_spec_names
end
def test_self_bin_path_no_exec_name
e = assert_raises ArgumentError do
Gem.bin_path 'a'