kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Revert "mkmf.rb: try linking at try_var" [Bug #18235]

Browse source 
This reverts commit 524513be39,
which can return false positive by existing but unusable symbol,
including functions.
This commit is contained in:
Nobuyoshi Nakada 2021-10-03 16:35:10 +09:00
parent b91b3000bd
commit ea64e742f5
No known key found for this signature in database
GPG key ID: 7CD2805BFA3770C6
2 changed files with 1 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/mkmf.rb
View file

@ -821,20 +821,12 @@ SRC
# You should use +have_var+ rather than +try_var+.
def try_var(var, headers = nil, opt = "", &b)
headers = cpp_include(headers)
try_compile(<<"SRC", opt, &b) or
try_compile(<<"SRC", opt, &b)
#{headers}
/*top*/
extern int t(void);
#{MAIN_DOES_NOTHING 't'}
int t(void) { const volatile void *volatile p; p = &(&#{var})[0]; return !p; }
SRC
try_link(<<"SRC", opt, &b)
#{headers}
/*top*/
extern int t(void);
#{MAIN_DOES_NOTHING 't'}
extern int #{var};
int t(void) { const volatile void *volatile p; p = &(&#{var})[0]; return !p; }
SRC
end

17
test/mkmf/test_have_var.rb
View file

@ -1,17 +0,0 @@
# frozen_string_literal: false
require_relative 'base'
require 'tempfile'
class TestMkmf
class TestHaveVar < TestMkmf
def test_have_var
assert_equal(true, have_var("ruby_version"), MKMFLOG)
assert_include($defs, '-DHAVE_RUBY_VERSION')
end
def test_not_have_var
assert_equal(false, have_var("rb_vm_something_flag"), MKMFLOG)
assert_not_include($defs, '-DHAVE_RB_VM_SOMETHING_FLAG')
end
end
end