diff --git a/ChangeLog b/ChangeLog index 26a28e6da8..5927a06e87 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +Fri Jan 2 09:08:31 2015 Tanaka Akira + + * lib/resolv.rb (Resolv::DNS::Label::Str#==): Check class equality. + (Resolv::DNS::Name#initialize): Normalize labels as + Resolv::DNS::Label::Str objects. + Thu Jan 1 21:41:49 2015 SHIBATA Hiroshi * doc/regexp.rdoc: fix regexp docs for whitespace character. diff --git a/lib/resolv.rb b/lib/resolv.rb index 3b7ab2a394..a801cf6ff4 100644 --- a/lib/resolv.rb +++ b/lib/resolv.rb @@ -1185,7 +1185,7 @@ class Resolv end def ==(other) - return @downcase == other.downcase + return self.class == other.class && @downcase == other.downcase end def eql?(other) @@ -1221,6 +1221,14 @@ class Resolv end def initialize(labels, absolute=true) # :nodoc: + labels = labels.map {|label| + case label + when String then Label::Str.new(label) + when Label::Str then label + else + raise ArgumentError, "unexpected label: #{label.inspect}" + end + } @labels = labels @absolute = absolute end diff --git a/test/resolv/test_dns.rb b/test/resolv/test_dns.rb index 8e54dd7904..d7e5c3683a 100644 --- a/test/resolv/test_dns.rb +++ b/test/resolv/test_dns.rb @@ -190,4 +190,11 @@ class TestResolvDNS < Test::Unit::TestCase upper = Resolv::DNS::Name.create("Ruby-Lang.org") assert_equal(lower, upper, bug10550) end + + def test_ipv6_name + addr = Resolv::IPv6.new("\0"*16) + labels = addr.to_name.to_a + expected = (['0'] * 32 + ['ip6', 'arpa']).map {|label| Resolv::DNS::Label::Str.new(label) } + assert_equal(expected, labels) + end end