diff --git a/ChangeLog b/ChangeLog index d9ce911c38..80709e82dd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Tue Feb 26 15:30:36 2008 Nobuyoshi Nakada + + * array.c (rb_ary_eql, rb_ary_cmp): get rid of stack overflow with + self-recursive constructs. [ruby-Bugs-18356] + Tue Feb 26 01:16:01 2008 Tanaka Akira * include/ruby/ruby.h (ROBJECT_NUMIV): renamed from ROBJECT_LEN. diff --git a/array.c b/array.c index 1f1526354d..b92d3fb5d3 100644 --- a/array.c +++ b/array.c @@ -317,7 +317,7 @@ rb_ary_initialize(int argc, VALUE *argv, VALUE ary) rb_raise(rb_eArgError, "array size too big"); } rb_ary_modify(ary); - RESIZE_CAPA(ary, len); + RESIZE_CAPA(ary, len); if (rb_block_given_p()) { long i; @@ -2343,6 +2343,19 @@ rb_ary_equal(VALUE ary1, VALUE ary2) return rb_exec_recursive(recursive_equal, ary1, ary2); } +static VALUE +recursive_eql(VALUE ary1, VALUE ary2, int recur) +{ + long i; + + if (recur) return Qfalse; + for (i=0; i true or false @@ -2354,16 +2367,10 @@ rb_ary_equal(VALUE ary1, VALUE ary2) static VALUE rb_ary_eql(VALUE ary1, VALUE ary2) { - long i; - if (ary1 == ary2) return Qtrue; if (TYPE(ary2) != T_ARRAY) return Qfalse; if (RARRAY_LEN(ary1) != RARRAY_LEN(ary2)) return Qfalse; - for (i=0; i RARRAY_LEN(ary2)) { + len = RARRAY_LEN(ary2); + } + for (i=0; i other_array -> -1, 0, +1 @@ -2448,19 +2474,13 @@ rb_ary_includes(VALUE ary, VALUE item) VALUE rb_ary_cmp(VALUE ary1, VALUE ary2) { - long i, len; + long len; + VALUE v; ary2 = to_ary(ary2); - len = RARRAY_LEN(ary1); - if (len > RARRAY_LEN(ary2)) { - len = RARRAY_LEN(ary2); - } - for (i=0; i 0) return INT2FIX(1);