diff --git a/ChangeLog b/ChangeLog index 0b6f1d5461..6c8eaf3928 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Fri Dec 5 00:17:18 2008 Nobuyoshi Nakada + + * string.c (sym_to_proc): caches Symbol procs, based on a patch from + Shumpei Akai . [ruby-dev:37265] + Thu Dec 4 23:29:34 2008 NAKAMURA Usaku * win32/win32.c (waitpid): fix bug of checking child slot. diff --git a/string.c b/string.c index d931cd9ca4..641018ab4d 100644 --- a/string.c +++ b/string.c @@ -6915,9 +6915,32 @@ sym_call(VALUE args, VALUE sym, int argc, VALUE *argv) static VALUE sym_to_proc(VALUE sym) { - return rb_proc_new(sym_call, (VALUE)SYM2ID(sym)); -} + static VALUE sym_proc_cache = Qfalse; + enum {SYM_PROC_CACHE_SIZE = 67}; + VALUE proc; + long id, index; + VALUE *aryp; + if (!sym_proc_cache) { + rb_gc_register_mark_object(sym_proc_cache); + sym_proc_cache = rb_ary_new2(SYM_PROC_CACHE_SIZE * 2); + rb_ary_store(sym_proc_cache, SYM_PROC_CACHE_SIZE*2 - 1, Qnil); + } + + id = SYM2ID(sym); + index = (id % SYM_PROC_CACHE_SIZE) << 1; + + aryp = RARRAY_PTR(sym_proc_cache); + if (aryp[index] == sym) { + return aryp[index + 1]; + } + else { + proc = rb_proc_new(sym_call, (VALUE)id); + aryp[index] = sym; + aryp[index + 1] = proc; + return proc; + } +} static VALUE sym_succ(VALUE sym)