kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Fix segfault when using method reference operator without using result

Browse source 
Fixes [Bug #15985]
This commit is contained in:
Jeremy Evans 2019-07-04 13:47:43 -07:00
parent 688cef2169
commit f296c260ef
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compile.c
View file

@ -8146,8 +8146,11 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *node, in
break; break;
} }
case NODE_METHREF: case NODE_METHREF:
CHECK(COMPILE_(ret, "receiver", node->nd_recv, popped)); CHECK(COMPILE(ret, "receiver", node->nd_recv));
ADD_ELEM(ret, &new_insn_body(iseq, line, BIN(methodref), 1, ID2SYM(node->nd_mid))->link); ADD_ELEM(ret, &new_insn_body(iseq, line, BIN(methodref), 1, ID2SYM(node->nd_mid))->link);
if (popped) {
ADD_INSN(ret, line, pop);
}
break; break;
default: default:
UNKNOWN_NODE("iseq_compile_each", node, COMPILE_NG); UNKNOWN_NODE("iseq_compile_each", node, COMPILE_NG);

7
test/ruby/test_syntax.rb
View file

@ -93,6 +93,13 @@ class TestSyntax < Test::Unit::TestCase
assert_valid_syntax("tap (proc do end)", __FILE__, bug9726) assert_valid_syntax("tap (proc do end)", __FILE__, bug9726)
end end
def test_methodref_literal
assert_separately [], <<-EOS
eval 'nil.:|;1'
1000.times{eval 'nil.:|;1'}
EOS
end
def test_normal_argument def test_normal_argument
assert_valid_syntax('def foo(x) end') assert_valid_syntax('def foo(x) end')
assert_syntax_error('def foo(X) end', /constant/) assert_syntax_error('def foo(X) end', /constant/)