1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

* lib/*.rb: Remove unused variable warnings.

Patch by Run Paint [ruby-core:30991]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@29726 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
marcandre 2010-11-08 20:59:01 +00:00
parent cceca83afe
commit f3e3547407
37 changed files with 62 additions and 73 deletions

View file

@ -1,3 +1,10 @@
Tue Nov 9 05:54:57 2010 Marc-Andre Lafortune <ruby-core@marc-andre.ca>
* lib/*.rb: Remove unused variable warnings.
Patch by Run Paint [ruby-core:30991]
* lib/rubygems/*, lib/rdoc/*.rb, lib/rake/*.rb: ditto
Mon Nov 8 18:26:03 2010 NARUSE, Yui <naruse@ruby-lang.org> Mon Nov 8 18:26:03 2010 NARUSE, Yui <naruse@ruby-lang.org>
* util.c (ruby_hdtoa): fix type cast and bufsize. * util.c (ruby_hdtoa): fix type cast and bufsize.

View file

@ -558,16 +558,16 @@ if __FILE__ == $0
n = ARGV[0].to_i.nonzero? || 50000 n = ARGV[0].to_i.nonzero? || 50000
puts %Q([#{n} times iterations of `a = "1"']) puts %Q([#{n} times iterations of `a = "1"'])
benchmark(" " + CAPTION, 7, FMTSTR) do |x| benchmark(" " + CAPTION, 7, FMTSTR) do |x|
x.report("for:") {for i in 1..n; a = "1"; end} # Benchmark::measure x.report("for:") {for _ in 1..n; _ = "1"; end} # Benchmark::measure
x.report("times:") {n.times do ; a = "1"; end} x.report("times:") {n.times do ; _ = "1"; end}
x.report("upto:") {1.upto(n) do ; a = "1"; end} x.report("upto:") {1.upto(n) do ; _ = "1"; end}
end end
benchmark do benchmark do
[ [
measure{for i in 1..n; a = "1"; end}, # Benchmark::measure measure{for _ in 1..n; _ = "1"; end}, # Benchmark::measure
measure{n.times do ; a = "1"; end}, measure{n.times do ; _ = "1"; end},
measure{1.upto(n) do ; a = "1"; end} measure{1.upto(n) do ; _ = "1"; end}
] ]
end end
end end

View file

@ -122,7 +122,7 @@ module DRb
end end
def self.open(uri, config) def self.open(uri, config)
host, port, option = parse_uri(uri) host, port, = parse_uri(uri)
host.untaint host.untaint
port.untaint port.untaint
soc = TCPSocket.open(host, port) soc = TCPSocket.open(host, port)
@ -134,7 +134,7 @@ module DRb
def self.open_server(uri, config) def self.open_server(uri, config)
uri = 'drbssl://:0' unless uri uri = 'drbssl://:0' unless uri
host, port, opt = parse_uri(uri) host, port, = parse_uri(uri)
if host.size == 0 if host.size == 0
host = getservername host = getservername
soc = open_server_inaddr_any(host, port) soc = open_server_inaddr_any(host, port)

View file

@ -64,7 +64,7 @@ module DRb
def keeper def keeper
Thread.new do Thread.new do
loop do loop do
size = alternate alternate
sleep(@timeout) sleep(@timeout)
end end
end end

View file

@ -19,14 +19,14 @@ module DRb
end end
def self.open(uri, config) def self.open(uri, config)
filename, option = parse_uri(uri) filename, = parse_uri(uri)
filename.untaint filename.untaint
soc = UNIXSocket.open(filename) soc = UNIXSocket.open(filename)
self.new(uri, soc, config) self.new(uri, soc, config)
end end
def self.open_server(uri, config) def self.open_server(uri, config)
filename, option = parse_uri(uri) filename, = parse_uri(uri)
if filename.size == 0 if filename.size == 0
soc = temp_server soc = temp_server
filename = soc.path filename = soc.path

View file

@ -29,12 +29,12 @@ module IRB
end end
def thread(key) def thread(key)
th, irb = search(key) th, = search(key)
th th
end end
def irb(key) def irb(key)
th, irb = search(key) _, irb = search(key)
irb irb
end end
@ -62,7 +62,7 @@ module IRB
def kill(*keys) def kill(*keys)
for key in keys for key in keys
th, irb = search(key) th, _ = search(key)
IRB.fail IrbAlreadyDead unless th.alive? IRB.fail IrbAlreadyDead unless th.alive?
th.exit th.exit
end end

View file

@ -10,5 +10,5 @@
# #
while true while true
IRB::BINDING_QUEUE.push b = binding IRB::BINDING_QUEUE.push _ = binding
end end

View file

@ -322,7 +322,7 @@ module Net
sock = TCPServer.open(@sock.addr[3], 0) sock = TCPServer.open(@sock.addr[3], 0)
port = sock.addr[1] port = sock.addr[1]
host = sock.addr[3] host = sock.addr[3]
resp = sendport(host, port) sendport(host, port)
return sock return sock
end end
private :makeport private :makeport

View file

@ -1563,7 +1563,7 @@ module Net #:nodoc:
# or sub-type is not given (e.g. "Content-Type: text"). # or sub-type is not given (e.g. "Content-Type: text").
def sub_type def sub_type
return nil unless @header['content-type'] return nil unless @header['content-type']
main, sub = *self['Content-Type'].split(';').first.to_s.split('/') _, sub = *self['Content-Type'].split(';').first.to_s.split('/')
return nil unless sub return nil unless sub
sub.strip sub.strip
end end

View file

@ -2680,7 +2680,6 @@ module Net
token = match(T_ATOM) token = match(T_ATOM)
name = token.value.upcase name = token.value.upcase
match(T_SPACE) match(T_SPACE)
mailbox = astring
data = [] data = []
token = lookahead token = lookahead
if token.symbol == T_SPACE if token.symbol == T_SPACE

View file

@ -105,13 +105,12 @@ module Racc
def _racc_do_parse_rb(arg, in_debug) def _racc_do_parse_rb(arg, in_debug)
action_table, action_check, action_default, action_pointer, action_table, action_check, action_default, action_pointer,
goto_table, goto_check, goto_default, goto_pointer, _, _, _, _,
nt_base, reduce_table, token_table, shift_n, _, _, token_table, _,
reduce_n, use_result, * = arg _, _, * = arg
_racc_init_sysvars _racc_init_sysvars
tok = act = i = nil tok = act = i = nil
nerr = 0
catch(:racc_end_parse) { catch(:racc_end_parse) {
while true while true
@ -154,14 +153,13 @@ module Racc
def _racc_yyparse_rb(recv, mid, arg, c_debug) def _racc_yyparse_rb(recv, mid, arg, c_debug)
action_table, action_check, action_default, action_pointer, action_table, action_check, action_default, action_pointer,
goto_table, goto_check, goto_default, goto_pointer, _, _, _, _,
nt_base, reduce_table, token_table, shift_n, _, _, token_table, _,
reduce_n, use_result, * = arg _, _, * = arg
_racc_init_sysvars _racc_init_sysvars
act = nil act = nil
i = nil i = nil
nerr = 0
catch(:racc_end_parse) { catch(:racc_end_parse) {
until i = action_pointer[@racc_state[-1]] until i = action_pointer[@racc_state[-1]]
@ -210,10 +208,10 @@ module Racc
### ###
def _racc_evalact(act, arg) def _racc_evalact(act, arg)
action_table, action_check, action_default, action_pointer, action_table, action_check, _, action_pointer,
goto_table, goto_check, goto_default, goto_pointer, _, _, _, _,
nt_base, reduce_table, token_table, shift_n, _, _, _, shift_n, reduce_n,
reduce_n, use_result, * = arg _, _, * = arg
nerr = 0 # tmp nerr = 0 # tmp
if act > 0 and act < shift_n if act > 0 and act < shift_n
@ -305,10 +303,10 @@ module Racc
end end
def _racc_do_reduce(arg, act) def _racc_do_reduce(arg, act)
action_table, action_check, action_default, action_pointer, _, _, _, _,
goto_table, goto_check, goto_default, goto_pointer, goto_table, goto_check, goto_default, goto_pointer,
nt_base, reduce_table, token_table, shift_n, nt_base, reduce_table, _, _,
reduce_n, use_result, * = arg _, use_result, * = arg
state = @racc_state state = @racc_state
vstack = @racc_vstack vstack = @racc_vstack
tstack = @racc_tstack tstack = @racc_tstack

View file

@ -115,7 +115,7 @@ module REXML
def doctype def doctype
if @element if @element
doc = @element.document doc = @element.document
doctype = doc.doctype if doc doc.doctype if doc
end end
end end

View file

@ -88,7 +88,7 @@ module REXML
# This doesn't yet handle encodings # This doesn't yet handle encodings
def bytes def bytes
encoding = document.encoding document.encoding
to_s to_s
end end

View file

@ -115,7 +115,6 @@ module REXML
output << " #{@long_name.inspect}" if @long_name output << " #{@long_name.inspect}" if @long_name
output << " #{@uri.inspect}" if @uri output << " #{@uri.inspect}" if @uri
unless @children.empty? unless @children.empty?
next_indent = indent + 1
output << ' [' output << ' ['
@children.each { |child| @children.each { |child|
output << "\n" output << "\n"

View file

@ -874,7 +874,6 @@ module REXML
# a.elements.add(Element.new('b')) #-> <a><b/></a> # a.elements.add(Element.new('b')) #-> <a><b/></a>
# a.elements.add('c') #-> <a><b/><c/></a> # a.elements.add('c') #-> <a><b/><c/></a>
def add element=nil def add element=nil
rv = nil
if element.nil? if element.nil?
Element.new("", self, @element.context) Element.new("", self, @element.context)
elsif not element.kind_of?(Element) elsif not element.kind_of?(Element)
@ -1092,7 +1091,7 @@ module REXML
delete attr delete attr
return return
end end
element_document = @element.document
unless value.kind_of? Attribute unless value.kind_of? Attribute
if @element.document and @element.document.doctype if @element.document and @element.document.doctype
value = Text::normalize( value, @element.document.doctype ) value = Text::normalize( value, @element.document.doctype )
@ -1197,7 +1196,7 @@ module REXML
return @element return @element
else # the supplied attribute is a top-level one else # the supplied attribute is a top-level one
attr = old attr = old
res = super(name) super(name)
end end
@element @element
end end

View file

@ -37,7 +37,6 @@ module REXML
# If compact and all children are text, and if the formatted output # If compact and all children are text, and if the formatted output
# is less than the specified width, then try to print everything on # is less than the specified width, then try to print everything on
# one line # one line
skip = false
@level += @indentation @level += @indentation
node.children.each { |child| node.children.each { |child|
write( child, output ) write( child, output )

View file

@ -170,7 +170,6 @@ module REXML
# Kouhei fixed this too # Kouhei fixed this too
def Functions::substring_after( string, test ) def Functions::substring_after( string, test )
ruby_string = string(string) ruby_string = string(string)
test_string = string(test)
return $1 if ruby_string =~ /#{test}(.*)/ return $1 if ruby_string =~ /#{test}(.*)/
"" ""
end end

View file

@ -87,7 +87,7 @@ module REXML
@listeners.each { |sym,match,block| @listeners.each { |sym,match,block|
block.start_document if sym == :start_document or sym.nil? block.start_document if sym == :start_document or sym.nil?
} }
root = context = [] context = []
while true while true
event = @parser.pull event = @parser.pull
case event[0] case event[0]

View file

@ -282,7 +282,6 @@ module REXML
PI = /^processing-instruction\(/ PI = /^processing-instruction\(/
def NodeTest path, parsed def NodeTest path, parsed
#puts "NodeTest with #{path}" #puts "NodeTest with #{path}"
res = nil
case path case path
when /^\*/ when /^\*/
path = $' path = $'
@ -578,7 +577,6 @@ module REXML
NUMBER = /^(\d*\.?\d+)/ NUMBER = /^(\d*\.?\d+)/
NT = /^comment|text|processing-instruction|node$/ NT = /^comment|text|processing-instruction|node$/
def PrimaryExpr path, parsed def PrimaryExpr path, parsed
arry = []
case path case path
when VARIABLE_REFERENCE when VARIABLE_REFERENCE
varname = $1 varname = $1

View file

@ -33,7 +33,6 @@ module REXML
results = filter(element.to_a, path) results = filter(element.to_a, path)
when /^[\[!\w:]/u when /^[\[!\w:]/u
# match on child # match on child
matches = []
children = element.to_a children = element.to_a
results = filter(children, path) results = filter(children, path)
else else
@ -51,8 +50,6 @@ module REXML
when /^\/\//u # Descendant when /^\/\//u # Descendant
return axe( elements, "descendant-or-self", $' ) return axe( elements, "descendant-or-self", $' )
when /^\/?\b(\w[-\w]*)\b::/u # Axe when /^\/?\b(\w[-\w]*)\b::/u # Axe
axe_name = $1
rest = $'
return axe( elements, $1, $' ) return axe( elements, $1, $' )
when /^\/(?=\b([:!\w][-\.\w]*:)?[-!\*\.\w]*\b([^:(]|$)|\*)/u # Child when /^\/(?=\b([:!\w][-\.\w]*:)?[-!\*\.\w]*\b([^:(]|$)|\*)/u # Child
rest = $' rest = $'

View file

@ -33,7 +33,7 @@ module REXML
sattr = [:start_attribute, nil] sattr = [:start_attribute, nil]
eattr = [:end_attribute] eattr = [:end_attribute]
text = [:text, nil] text = [:text, nil]
k,v = event[2].find { |key,value| k, = event[2].find { |key,value|
sattr[1] = key sattr[1] = key
#puts "Looking for #{sattr.inspect}" #puts "Looking for #{sattr.inspect}"
m = @current.next( sattr ) m = @current.next( sattr )

View file

@ -687,7 +687,7 @@ module REXML
return rv return rv
else else
res = [] res = []
enum = SyncEnumerator.new( set1, set2 ).each { |i1, i2| SyncEnumerator.new( set1, set2 ).each { |i1, i2|
#puts "i1 = #{i1.inspect} (#{i1.class.name})" #puts "i1 = #{i1.inspect} (#{i1.class.name})"
#puts "i2 = #{i2.inspect} (#{i2.class.name})" #puts "i2 = #{i2.inspect} (#{i2.class.name})"
i1 = norm( i1 ) i1 = norm( i1 )

View file

@ -198,7 +198,7 @@ module Rinda
def lookup_ring_any(timeout=5) def lookup_ring_any(timeout=5)
queue = Queue.new queue = Queue.new
th = Thread.new do Thread.new do
self.lookup_ring(timeout) do |ts| self.lookup_ring(timeout) do |ts|
queue.push(ts) queue.push(ts)
end end
@ -252,7 +252,7 @@ if __FILE__ == $0
when 's' when 's'
require 'rinda/tuplespace' require 'rinda/tuplespace'
ts = Rinda::TupleSpace.new ts = Rinda::TupleSpace.new
place = Rinda::RingServer.new(ts) Rinda::RingServer.new(ts)
$stdin.gets $stdin.gets
when 'w' when 'w'
finger = Rinda::RingFinger.new(nil) finger = Rinda::RingFinger.new(nil)

View file

@ -527,7 +527,7 @@ module RSS
return false unless inline_other? return false unless inline_other?
return false if inline_other_xml? return false if inline_other_xml?
media_type, subtype = mime_split media_type, = mime_split
return true if "text" == media_type.downcase return true if "text" == media_type.downcase
false false
end end

View file

@ -24,7 +24,7 @@ module RSS
class Channel < ChannelBase class Channel < ChannelBase
def to_feed(rss) def to_feed(rss)
channel = Rss::Channel.new channel = Rss::Channel.new
set = setup_values(channel) setup_values(channel)
_not_set_required_variables = not_set_required_variables _not_set_required_variables = not_set_required_variables
if _not_set_required_variables.empty? if _not_set_required_variables.empty?
rss.channel = channel rss.channel = channel
@ -257,7 +257,7 @@ module RSS
class Item < ItemBase class Item < ItemBase
def to_feed(rss) def to_feed(rss)
item = Rss::Channel::Item.new item = Rss::Channel::Item.new
set = setup_values(item) setup_values(item)
_not_set_required_variables = not_set_required_variables _not_set_required_variables = not_set_required_variables
if _not_set_required_variables.empty? if _not_set_required_variables.empty?
rss.items << item rss.items << item

View file

@ -32,7 +32,7 @@ module RSS
_not_set_required_variables = not_set_required_variables _not_set_required_variables = not_set_required_variables
if _not_set_required_variables.empty? if _not_set_required_variables.empty?
channel = RDF::Channel.new(@about) channel = RDF::Channel.new(@about)
set = setup_values(channel) setup_values(channel)
channel.dc_dates.clear channel.dc_dates.clear
rss.channel = channel rss.channel = channel
set_parent(channel, rss) set_parent(channel, rss)

View file

@ -11,10 +11,7 @@ module RSS
plural_name ||= "#{name}s" plural_name ||= "#{name}s"
full_name = "#{RSS::DC_PREFIX}_#{name}" full_name = "#{RSS::DC_PREFIX}_#{name}"
full_plural_name = "#{RSS::DC_PREFIX}_#{plural_name}" full_plural_name = "#{RSS::DC_PREFIX}_#{plural_name}"
klass_name = Utils.to_class_name(name)
plural_klass_name = "DublinCore#{Utils.to_class_name(plural_name)}" plural_klass_name = "DublinCore#{Utils.to_class_name(plural_name)}"
full_plural_klass_name = "self.class::#{plural_klass_name}"
full_klass_name = "#{full_plural_klass_name}::#{klass_name}"
klass.def_classed_elements(full_name, "value", plural_klass_name, klass.def_classed_elements(full_name, "value", plural_klass_name,
full_plural_name, name) full_plural_name, name)
klass.module_eval(<<-EOC, __FILE__, __LINE__ + 1) klass.module_eval(<<-EOC, __FILE__, __LINE__ + 1)

View file

@ -1093,9 +1093,8 @@ EOC
tags = tags.sort_by {|x| element_names.index(x) || tags_size} tags = tags.sort_by {|x| element_names.index(x) || tags_size}
end end
_tags = tags.dup if tags
models.each_with_index do |model, i| models.each_with_index do |model, i|
name, model_uri, occurs, getter = model name, _, occurs, = model
if DEBUG if DEBUG
p "before" p "before"

View file

@ -84,7 +84,7 @@ class Shell
notify "Job(%id) start imp-pipe.", @shell.debug? notify "Job(%id) start imp-pipe.", @shell.debug?
rs = @shell.record_separator unless rs rs = @shell.record_separator unless rs
_eop = true _eop = true
th = Thread.start { Thread.start {
begin begin
while l = @pipe_in.gets while l = @pipe_in.gets
@input_queue.push l @input_queue.push l
@ -109,7 +109,7 @@ class Shell
def start_export def start_export
notify "job(%id) start exp-pipe.", @shell.debug? notify "job(%id) start exp-pipe.", @shell.debug?
_eop = true _eop = true
th = Thread.start{ Thread.start{
begin begin
@input.each do |l| @input.each do |l|
ProcessController::block_output_synchronize do ProcessController::block_output_synchronize do

View file

@ -128,9 +128,8 @@ module Sync_m
def sync_try_lock(mode = EX) def sync_try_lock(mode = EX)
return unlock if mode == UN return unlock if mode == UN
@sync_mutex.synchronize do @sync_mutex.synchronize do
ret = sync_try_lock_sub(mode) sync_try_lock_sub(mode)
end end
ret
end end
def sync_lock(m = EX) def sync_lock(m = EX)

View file

@ -143,7 +143,7 @@ module WEBrick
setup_header setup_header
@header_part << CRLF @header_part << CRLF
@header_part.rewind @header_part.rewind
rescue Exception => ex rescue Exception
raise CGIError, "invalid CGI environment" raise CGIError, "invalid CGI environment"
end end
end end

View file

@ -280,7 +280,7 @@ module WEBrick
if @request_method == "HEAD" if @request_method == "HEAD"
# do nothing # do nothing
elsif chunked? elsif chunked?
remain = body ? @body.bytesize : 0 body ? @body.bytesize : 0
while buf = @body[@sent_size, @buffer_size] while buf = @body[@sent_size, @buffer_size]
break if buf.empty? break if buf.empty?
data = "" data = ""

View file

@ -20,7 +20,6 @@ end
STDIN.binmode STDIN.binmode
buf = ""
len = sysread(STDIN, 8).to_i len = sysread(STDIN, 8).to_i
out = sysread(STDIN, len) out = sysread(STDIN, len)
STDOUT.reopen(open(out, "w")) STDOUT.reopen(open(out, "w"))
@ -38,7 +37,7 @@ hash.each{|k, v| ENV[k] = v if v }
dir = File::dirname(ENV["SCRIPT_FILENAME"]) dir = File::dirname(ENV["SCRIPT_FILENAME"])
Dir::chdir dir Dir::chdir dir
if interpreter = ARGV[0] if ARGV[0]
argv = ARGV.dup argv = ARGV.dup
argv << ENV["SCRIPT_FILENAME"] argv << ENV["SCRIPT_FILENAME"]
exec(*argv) exec(*argv)

View file

@ -44,8 +44,8 @@ module WEBrick
private private
def evaluate(erb, servlet_request, servlet_response) def evaluate(erb, servlet_request, servlet_response)
Module.new.module_eval{ Module.new.module_eval{
meta_vars = servlet_request.meta_vars servlet_request.meta_vars
query = servlet_request.query servlet_request.query
erb.result(binding) erb.result(binding)
} }
end end

View file

@ -60,7 +60,7 @@ module WEBrick
private private
def format(arg) def format(arg)
str = if arg.is_a?(Exception) if arg.is_a?(Exception)
"#{arg.class}: #{arg.message}\n\t" << "#{arg.class}: #{arg.message}\n\t" <<
arg.backtrace.join("\n\t") << "\n" arg.backtrace.join("\n\t") << "\n"
elsif arg.respond_to?(:to_str) elsif arg.respond_to?(:to_str)

View file

@ -170,7 +170,7 @@ private
io << http_resp(response.status, response.status_message, io << http_resp(response.status, response.status_message,
response.header, response.body) response.header, response.body)
rescue Exception => e rescue Exception
io << http_resp(500, "Internal Server Error") io << http_resp(500, "Internal Server Error")
end end

View file

@ -714,7 +714,7 @@ module XMLRPC
end end
def parse(str) def parse(str)
parser = REXML::Document.parse_stream(str, self) REXML::Document.parse_stream(str, self)
end end
end end