kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* lib/matrix.rb: Fix Matrix.rows copy bug.

Browse source 
Patch by Arron Mabrey. [Fix GH-707]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
marcandre 2014-10-03 03:38:06 +00:00
parent 1b5acebef2
commit f59098d118
3 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
Fri Oct 3 12:37:48 2014 Marc-Andre Lafortune <ruby-core@marc-andre.ca>
* lib/matrix.rb: Fix Matrix.rows copy bug.
Patch by Arron Mabrey. [Fix GH-707]
Fri Oct 3 06:06:28 2014 Eric Wong <e@80x24.org>
* st.c (next_pow2): new function (from old bignum.c)

2
lib/matrix.rb
View file

@ -152,7 +152,7 @@ class Matrix
# -1 66
#
def Matrix.rows(rows, copy = true)
rows = convert_to_array(rows)
rows = convert_to_array(rows, copy)
rows.map! do |row|
convert_to_array(row, copy)
end

14
test/matrix/test_matrix.rb
View file

@ -177,6 +177,20 @@ class TestMatrix < Test::Unit::TestCase
assert_equal(@m1, Matrix.rows([[1, 2, 3], [4, 5, 6]]))
end
def test_rows_copy
rows1 = [[1], [1]]
rows2 = [[1], [1]]
m1 = Matrix.rows(rows1, copy = false)
m2 = Matrix.rows(rows2, copy = true)
rows1.uniq!
rows2.uniq!
assert_equal([[1]], m1.to_a)
assert_equal([[1], [1]], m2.to_a)
end
def test_columns
assert_equal(@m1, Matrix.columns([[1, 4], [2, 5], [3, 6]]))
end