kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

class.c: missing unknown_keyword_error

Browse source 
* class.c (rb_get_kwargs): when values are stored, corresponding
  keys have been remove from the keyword hash, and the hash should
  be empty in that case.  [ruby-dev:49893] [Bug #13004]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nobu 2016-12-04 08:50:29 +00:00
parent b62e322017
commit f5ef84cb5e
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
class.c
View file

@ -1896,7 +1896,7 @@ rb_get_kwargs(VALUE keyword_hash, const ID *table, int required, int optional, V
}
}
if (!rest && keyword_hash) {
if (RHASH_SIZE(keyword_hash) > (unsigned int)j) {
if (RHASH_SIZE(keyword_hash) > (unsigned int)(values ? 0 : j)) {
unknown_keyword_error(keyword_hash, table, required+optional);
}
}

7
test/ruby/test_keyword.rb
View file

@ -546,6 +546,13 @@ class TestKeywordArguments < Test::Unit::TestCase
}
end
def test_unknown_keyword
bug13004 = '[ruby-dev:49893] [Bug #13004]'
assert_raise_with_message(ArgumentError, /unknown keyword: invalid-argument/, bug13004) {
[].sample(random: nil, "invalid-argument": nil)
}
end
def test_super_with_anon_restkeywords
bug10659 = '[ruby-core:67157] [Bug #10659]'