kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[ruby/did_you_mean] Fixed correction duplicates in VariableNameChecker

Browse source 
https://github.com/ruby/did_you_mean/commit/c3fc412f6f
This commit is contained in:
Imir Kiyamov 2022-05-20 16:32:11 +03:00 • committed by git
parent 55b1600987
commit f67ab7f30c
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb
View file

@ -79,7 +79,7 @@ module DidYouMean
def corrections
@corrections ||= SpellChecker
.new(dictionary: (RB_RESERVED_WORDS + lvar_names + method_names + ivar_names + cvar_names))
.correct(name) - NAMES_TO_EXCLUDE[@name]
.correct(name).uniq - NAMES_TO_EXCLUDE[@name]
end
end
end

12
test/did_you_mean/spell_checking/test_variable_name_check.rb
View file

@ -137,4 +137,16 @@ class VariableNameCheckTest < Test::Unit::TestCase
error = assert_raise(NameError){ foo }
assert_empty error.corrections
end
def test_exclude_duplicates_with_same_name
error = assert_raise(NameError) do
eval(<<~RUBY, binding, __FILE__, __LINE__)
bar = 1
def bar;end
zar
RUBY
end
assert_correction [:bar], error.corrections
end
end