kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Limit bactrace length from Exception#full_message

Browse source
This commit is contained in:
Nobuyoshi Nakada 2020-12-27 20:50:15 +09:00
parent 730b0099fd
commit f6a080047e
No known key found for this signature in database
GPG key ID: 7CD2805BFA3770C6
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
eval_error.c
View file

@ -228,7 +228,7 @@ print_errinfo(const VALUE eclass, const VALUE errat, const VALUE emesg, const VA
} }
static void static void
print_backtrace(const VALUE eclass, const VALUE errat, const VALUE str, int reverse) print_backtrace(const VALUE eclass, const VALUE errat, const VALUE str, int reverse, long backtrace_limit)
{ {
if (!NIL_P(errat)) { if (!NIL_P(errat)) {
long i; long i;
@ -253,8 +253,8 @@ print_backtrace(const VALUE eclass, const VALUE errat, const VALUE str, int reve
} }
// skip for explicit limit // skip for explicit limit
if (rb_backtrace_length_limit >= 0 && len > rb_backtrace_length_limit + 2) { if (backtrace_limit >= 0 && len > backtrace_limit + 2) {
skip_start = rb_backtrace_length_limit + 1; skip_start = backtrace_limit + 1;
skip_len = len - skip_start; skip_len = len - skip_start;
} }
@ -289,7 +289,7 @@ shown_cause_p(VALUE cause, VALUE *shown_causes)
} }
static void static void
show_cause(VALUE errinfo, VALUE str, VALUE highlight, VALUE reverse, VALUE *shown_causes) show_cause(VALUE errinfo, VALUE str, VALUE highlight, VALUE reverse, long backtrace_limit, VALUE *shown_causes)
{ {
VALUE cause = rb_attr_get(errinfo, id_cause); VALUE cause = rb_attr_get(errinfo, id_cause);
if (!NIL_P(cause) && rb_obj_is_kind_of(cause, rb_eException) && if (!NIL_P(cause) && rb_obj_is_kind_of(cause, rb_eException) &&
@ -298,14 +298,14 @@ show_cause(VALUE errinfo, VALUE str, VALUE highlight, VALUE reverse, VALUE *show
VALUE errat = rb_get_backtrace(cause); VALUE errat = rb_get_backtrace(cause);
VALUE emesg = rb_get_message(cause); VALUE emesg = rb_get_message(cause);
if (reverse) { if (reverse) {
show_cause(cause, str, highlight, reverse, shown_causes); show_cause(cause, str, highlight, reverse, backtrace_limit, shown_causes);
print_backtrace(eclass, errat, str, TRUE); print_backtrace(eclass, errat, str, TRUE, backtrace_limit);
print_errinfo(eclass, errat, emesg, str, highlight!=0); print_errinfo(eclass, errat, emesg, str, highlight!=0);
} }
else { else {
print_errinfo(eclass, errat, emesg, str, highlight!=0); print_errinfo(eclass, errat, emesg, str, highlight!=0);
print_backtrace(eclass, errat, str, FALSE); print_backtrace(eclass, errat, str, FALSE, backtrace_limit);
show_cause(cause, str, highlight, reverse, shown_causes); show_cause(cause, str, highlight, reverse, backtrace_limit, shown_causes);
} }
} }
} }
@ -315,6 +315,7 @@ rb_error_write(VALUE errinfo, VALUE emesg, VALUE errat, VALUE str, VALUE highlig
{ {
volatile VALUE eclass; volatile VALUE eclass;
VALUE shown_causes = 0; VALUE shown_causes = 0;
long backtrace_limit = rb_backtrace_length_limit;
if (NIL_P(errinfo)) if (NIL_P(errinfo))
return; return;
@ -345,14 +346,14 @@ rb_error_write(VALUE errinfo, VALUE emesg, VALUE errat, VALUE str, VALUE highlig
len = p - (msg = buff); len = p - (msg = buff);
} }
write_warn2(str, msg, len); write_warn2(str, msg, len);
show_cause(errinfo, str, highlight, reverse, &shown_causes); show_cause(errinfo, str, highlight, reverse, backtrace_limit, &shown_causes);
print_backtrace(eclass, errat, str, TRUE); print_backtrace(eclass, errat, str, TRUE, backtrace_limit);
print_errinfo(eclass, errat, emesg, str, highlight!=0); print_errinfo(eclass, errat, emesg, str, highlight!=0);
} }
else { else {
print_errinfo(eclass, errat, emesg, str, highlight!=0); print_errinfo(eclass, errat, emesg, str, highlight!=0);
print_backtrace(eclass, errat, str, FALSE); print_backtrace(eclass, errat, str, FALSE, backtrace_limit);
show_cause(errinfo, str, highlight, reverse, &shown_causes); show_cause(errinfo, str, highlight, reverse, backtrace_limit, &shown_causes);
} }
} }