diff --git a/ChangeLog b/ChangeLog index 595f019b45..919b614b3c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2014-02-22 Kouhei Sutou + + * test/rexml/xpath/test_attribute.rb: Simplify. + Sat Feb 22 20:28:47 2014 NAKAMURA Usaku * tool/redmine-backporter.rb: more friendly. diff --git a/test/rexml/xpath/test_attribute.rb b/test/rexml/xpath/test_attribute.rb index 9af83a3081..81a39bb9d2 100644 --- a/test/rexml/xpath/test_attribute.rb +++ b/test/rexml/xpath/test_attribute.rb @@ -2,84 +2,26 @@ require 'test/unit' require 'rexml/document' class TestXPathAttribute < Test::Unit::TestCase - - # xmlstr1 and xmlstr2 only differ in the second line - namespaces in the root element - @@xmlstr1 = ' - - http://www.google.com/calendar/feeds/me%40gmail.com - - http://www.google.com/calendar/feeds/me%40gmail.com/me%40gmail.com - 2007-05-16T13:42:27.942Z - 2007-05-15T03:29:28.000Z - My Calendar - - - - - Me - me@gmail.com - - -' - - - @@xmlstr2 = ' - - http://www.google.com/calendar/feeds/me%40gmail.com - - http://www.google.com/calendar/feeds/me%40gmail.com/me%40gmail.com - 2007-05-16T13:42:27.942Z - 2007-05-15T03:29:28.000Z - My Calendar - - - - - Me - me@gmail.com - - -' - - # Fails - def test_xpath_query - do_test @@xmlstr1 + def setup + @xml = <<-XML + + + child1 + child2 + child3 + + XML + @document = REXML::Document.new(@xml) end - # Passes - def test_xpath_query_no_namespace - do_test @@xmlstr2 + def test_elements + root = @document.elements["root"] + second_child = root.elements["child[@name='two']"] + assert_equal("child2", second_child.text) end - def do_test(xmlString) - hrefs = [ - "http://www.google.com/calendar/feeds/me%40gmail.com/private/full", - "http://www.google.com/calendar/feeds/me%40gmail.com/acl/full", - "http://www.google.com/calendar/feeds/me%40gmail.com/me%40gmail.com" - ] - ctr=0 - REXML::Document.new(xmlString).elements.each("feed/entry") do |element| - @alternate_link = element.elements["link[@rel='alternate']"] - assert_not_nil( @alternate_link ) - assert_equal( hrefs[ctr], @alternate_link.attributes['href']) - ctr += 1 - end - end - - - def test_another_way - doc = REXML::Document.new(@@xmlstr1) - hrefs = [ - "http://www.google.com/calendar/feeds/me%40gmail.com/private/full", - "http://www.google.com/calendar/feeds/me%40gmail.com/acl/full", - "http://www.google.com/calendar/feeds/me%40gmail.com/me%40gmail.com" - ] - ctr=0 - REXML::XPath.each(doc, "//link[@rel='alternate']") do |element| - @alternate_link = element - assert_not_nil @alternate_link - assert_equal( hrefs[ctr], @alternate_link.attributes['href']) - ctr += 1 - end + def test_xpath_each + children = REXML::XPath.each(@document, "/root/child[@name='two']") + assert_equal(["child2"], children.collect(&:text)) end end