1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

[rubygems/rubygems] Only disallow FIXME/TODO for first word of gemspec description

7890c98 matched the start of each line, whereas this matches the start
of the entire string.

https://github.com/rubygems/rubygems/commit/432de7b819
This commit is contained in:
Ellen Marie Dash 2021-09-24 17:54:08 -04:00 committed by Hiroshi SHIBATA
parent 6874d4f116
commit fcaa918445
2 changed files with 15 additions and 1 deletions

View file

@ -381,7 +381,7 @@ http://spdx.org/licenses or '#{Gem::Licenses::NONSTANDARD}' for a nonstandard li
end
LAZY = '"FIxxxXME" or "TOxxxDO"'.gsub(/xxx/, '')
LAZY_PATTERN = /^FI XME|^TO DO/x.freeze
LAZY_PATTERN = /\AFI XME|\ATO DO/x.freeze
HOMEPAGE_URI_PATTERN = /\A[a-z][a-z\d+.-]*:/i.freeze
def validate_lazy_metadata

View file

@ -2795,6 +2795,20 @@ duplicate dependency on c (>= 1.2.3, development), (~> 1.2) use:
assert_nothing_raised do
@a1.validate
end
# Adding #{f} at the start of the second or later line should be fine.
@a1.description = "(some description)\n#{f}"
assert_nothing_raised do
@a1.validate
end
# Adding #{t} at the start of the second or later line should be fine.
@a1.description = "(some description)\n#{t}"
assert_nothing_raised do
@a1.validate
end
end
end