1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
ruby--ruby/test/-ext-/string/test_cstr.rb
Jeremy Evans 58325daae3 Make String methods return String instances when called on a subclass instance
This modifies the following String methods to return String instances
instead of subclass instances:

* String#*
* String#capitalize
* String#center
* String#chomp
* String#chop
* String#delete
* String#delete_prefix
* String#delete_suffix
* String#downcase
* String#dump
* String#each/#each_line
* String#gsub
* String#ljust
* String#lstrip
* String#partition
* String#reverse
* String#rjust
* String#rpartition
* String#rstrip
* String#scrub
* String#slice!
* String#slice/#[]
* String#split
* String#squeeze
* String#strip
* String#sub
* String#succ/#next
* String#swapcase
* String#tr
* String#tr_s
* String#upcase

This also fixes a bug in String#swapcase where it would return the
receiver instead of a copy of the receiver if the receiver was the
empty string.

Some string methods were left to return subclass instances:

* String#+@
* String#-@

Both of these methods will return the receiver (subclass instance)
in some cases, so it is best to keep the returned class consistent.

Fixes [#10845]
2020-11-20 16:30:23 -08:00

164 lines
4 KiB
Ruby

# frozen_string_literal: false
require 'test/unit'
require "-test-/string"
class Test_StringCStr < Test::Unit::TestCase
Bug4319 = '[ruby-dev:43094]'
def test_embed
s = Bug::String.new("abcdef")
s.set_len(3)
s.cstr_unterm('x')
assert_equal(0, s.cstr_term, Bug4319)
end
def test_long
s = Bug::String.new(Bug::String.new("abcdef")*100000)
s.cstr_unterm('x')
assert_equal(0, s.cstr_term, Bug4319)
end
def test_shared
s = Bug::String.new(Bug::String.new("abcdef")*5)
s = s.unterminated_substring(0, 29)
assert_equal(0, s.cstr_term, Bug4319)
end
def test_frozen
s0 = Bug::String.new("abcdefgh"*8)
[4, 4*3-1, 8*3-1, 64].each do |n|
s = Bug::String.new(s0[0, n])
s.cstr_unterm('x')
s.freeze
assert_equal(0, s.cstr_term)
WCHARS.each do |enc|
s = s0.encode(enc)
s.set_len(n - n % s[0].bytesize)
s.cstr_unterm('x')
s.freeze
assert_equal(0, s.cstr_term)
end
end
end
def test_rb_str_new_frozen_embed
str = Bug::String.cstr_noembed("rbconfig.rb")
str = Bug::String.rb_str_new_frozen(str)
assert_equal true, Bug::String.cstr_embedded?(str)
end
WCHARS = [Encoding::UTF_16BE, Encoding::UTF_16LE, Encoding::UTF_32BE, Encoding::UTF_32LE]
def test_wchar_embed
WCHARS.each do |enc|
s = Bug::String.new("\u{4022}a".encode(enc))
s.cstr_unterm('x')
assert_nothing_raised(ArgumentError) {s.cstr_term}
s.set_len(s.bytesize / 2)
assert_equal(1, s.size)
s.cstr_unterm('x')
assert_equal(0, s.cstr_term)
end
end
def test_wchar_long
str = "\u{4022}abcdef"
n = 100
len = str.size * n
WCHARS.each do |enc|
s = Bug::String.new(Bug::String.new(str.encode(enc))*n)
s.cstr_unterm('x')
assert_nothing_raised(ArgumentError, enc.name) {s.cstr_term}
s.set_len(s.bytesize / 2)
assert_equal(len / 2, s.size, enc.name)
s.cstr_unterm('x')
assert_equal(0, s.cstr_term, enc.name)
end
end
def test_wchar_lstrip!
assert_wchars_term_char(" a") {|s| s.lstrip!}
end
def test_wchar_rstrip!
assert_wchars_term_char("a ") {|s| s.rstrip!}
end
def test_wchar_chop!
assert_wchars_term_char("a\n") {|s| s.chop!}
end
def test_wchar_chomp!
assert_wchars_term_char("a\n") {|s| s.chomp!}
end
def test_wchar_aset
assert_wchars_term_char("a"*30) {|s| s[29,1] = ""}
end
def test_wchar_sub!
assert_wchars_term_char("foobar") {|s| s.sub!(/#{"foo".encode(s.encoding)}/, "")}
end
def test_wchar_delete!
assert_wchars_term_char("foobar") {|s| s.delete!("ao".encode(s.encoding))}
end
def test_wchar_squeeze!
assert_wchars_term_char("foo!") {|s| s.squeeze!}
end
def test_wchar_tr!
assert_wchars_term_char("\u{3042}foobar") {|s|
enc = s.encoding
s.tr!("\u{3042}".encode(enc), "c".encode(enc))
}
end
def test_wchar_tr_s!
assert_wchars_term_char("\u{3042}foobar") {|s|
enc = s.encoding
s.tr_s!("\u{3042}".encode(enc), "c".encode(enc))
}
end
def test_wchar_replace
assert_wchars_term_char("abc") {|s|
w = s.dup
s.replace("abcdefghijklmnop")
s.replace(w)
}
end
def test_embedded_from_heap
gh821 = "[GH-821]"
embedded_string = "abcdefghi"
string = embedded_string.gsub("efg", "123")
{}[string] = 1
non_terminated = "#{string}#{nil}"
assert_nil(Bug::String.cstr_term_char(non_terminated), gh821)
result = {}
WCHARS.map do |enc|
embedded_string = "ab".encode(enc)
string = embedded_string.gsub("b".encode(enc), "1".encode(enc))
{}[string] = 1
non_terminated = "#{string}#{nil}"
c = Bug::String.cstr_term_char(non_terminated)
result[enc] = c if c
end
assert_empty(result, gh821)
end
def assert_wchars_term_char(str)
result = {}
WCHARS.map do |enc|
s = Bug::String.new(str.encode(enc))
yield s
c = s.cstr_term_char
result[enc] = c if c
end
assert_empty(result)
end
end