mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
8598f8c2dc
rubygems 2.7.x depends bundler-1.15.x. This is preparation for
rubygems and bundler migration.
* lib/bundler.rb, lib/bundler/*: files of bundler-1.15.4
* spec/bundler/*: rspec examples of bundler-1.15.4. I applied patches.
* https://github.com/bundler/bundler/pull/6007
* Exclude not working examples on ruby repository.
* Fake ruby interpriter instead of installed ruby.
* Makefile.in: Added test task named `test-bundler`. This task is only
working macOS/linux yet. I'm going to support Windows environment later.
* tool/sync_default_gems.rb: Added sync task for bundler.
[Feature #12733][ruby-core:77172]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
703 lines
16 KiB
Ruby
703 lines
16 KiB
Ruby
# frozen_string_literal: true
|
|
require "spec_helper"
|
|
|
|
RSpec.describe "bundle clean" do
|
|
def should_have_gems(*gems)
|
|
gems.each do |g|
|
|
expect(vendored_gems("gems/#{g}")).to exist
|
|
expect(vendored_gems("specifications/#{g}.gemspec")).to exist
|
|
expect(vendored_gems("cache/#{g}.gem")).to exist
|
|
end
|
|
end
|
|
|
|
def should_not_have_gems(*gems)
|
|
gems.each do |g|
|
|
expect(vendored_gems("gems/#{g}")).not_to exist
|
|
expect(vendored_gems("specifications/#{g}.gemspec")).not_to exist
|
|
expect(vendored_gems("cache/#{g}.gem")).not_to exist
|
|
end
|
|
end
|
|
|
|
it "removes unused gems that are different" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
gem "foo"
|
|
G
|
|
|
|
bundle "install --path vendor/bundle --no-clean"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
G
|
|
bundle "install"
|
|
|
|
bundle :clean
|
|
|
|
expect(out).to include("Removing foo (1.0)")
|
|
|
|
should_have_gems "thin-1.0", "rack-1.0.0"
|
|
should_not_have_gems "foo-1.0"
|
|
|
|
expect(vendored_gems("bin/rackup")).to exist
|
|
end
|
|
|
|
it "removes old version of gem if unused" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", "0.9.1"
|
|
gem "foo"
|
|
G
|
|
|
|
bundle "install --path vendor/bundle --no-clean"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", "1.0.0"
|
|
gem "foo"
|
|
G
|
|
bundle "install"
|
|
|
|
bundle :clean
|
|
|
|
expect(out).to include("Removing rack (0.9.1)")
|
|
|
|
should_have_gems "foo-1.0", "rack-1.0.0"
|
|
should_not_have_gems "rack-0.9.1"
|
|
|
|
expect(vendored_gems("bin/rackup")).to exist
|
|
end
|
|
|
|
it "removes new version of gem if unused" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", "1.0.0"
|
|
gem "foo"
|
|
G
|
|
|
|
bundle "install --path vendor/bundle --no-clean"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", "0.9.1"
|
|
gem "foo"
|
|
G
|
|
bundle "install"
|
|
|
|
bundle :clean
|
|
|
|
expect(out).to include("Removing rack (1.0.0)")
|
|
|
|
should_have_gems "foo-1.0", "rack-0.9.1"
|
|
should_not_have_gems "rack-1.0.0"
|
|
|
|
expect(vendored_gems("bin/rackup")).to exist
|
|
end
|
|
|
|
it "removes gems in bundle without groups" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "foo"
|
|
|
|
group :test_group do
|
|
gem "rack", "1.0.0"
|
|
end
|
|
G
|
|
|
|
bundle "install --path vendor/bundle"
|
|
bundle "install --without test_group"
|
|
bundle :clean
|
|
|
|
expect(out).to include("Removing rack (1.0.0)")
|
|
|
|
should_have_gems "foo-1.0"
|
|
should_not_have_gems "rack-1.0.0"
|
|
|
|
expect(vendored_gems("bin/rackup")).to_not exist
|
|
end
|
|
|
|
it "does not remove cached git dir if it's being used" do
|
|
build_git "foo"
|
|
revision = revision_for(lib_path("foo-1.0"))
|
|
git_path = lib_path("foo-1.0")
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", "1.0.0"
|
|
git "#{git_path}", :ref => "#{revision}" do
|
|
gem "foo"
|
|
end
|
|
G
|
|
|
|
bundle "install --path vendor/bundle"
|
|
|
|
bundle :clean
|
|
|
|
digest = Digest::SHA1.hexdigest(git_path.to_s)
|
|
expect(vendored_gems("cache/bundler/git/foo-1.0-#{digest}")).to exist
|
|
end
|
|
|
|
it "removes unused git gems" do
|
|
build_git "foo", :path => lib_path("foo")
|
|
git_path = lib_path("foo")
|
|
revision = revision_for(git_path)
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", "1.0.0"
|
|
git "#{git_path}", :ref => "#{revision}" do
|
|
gem "foo"
|
|
end
|
|
G
|
|
|
|
bundle "install --path vendor/bundle"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", "1.0.0"
|
|
G
|
|
bundle "install"
|
|
|
|
bundle :clean
|
|
|
|
expect(out).to include("Removing foo (#{revision[0..11]})")
|
|
|
|
expect(vendored_gems("gems/rack-1.0.0")).to exist
|
|
expect(vendored_gems("bundler/gems/foo-#{revision[0..11]}")).not_to exist
|
|
digest = Digest::SHA1.hexdigest(git_path.to_s)
|
|
expect(vendored_gems("cache/bundler/git/foo-#{digest}")).not_to exist
|
|
|
|
expect(vendored_gems("specifications/rack-1.0.0.gemspec")).to exist
|
|
|
|
expect(vendored_gems("bin/rackup")).to exist
|
|
end
|
|
|
|
it "removes old git gems" do
|
|
build_git "foo-bar", :path => lib_path("foo-bar")
|
|
revision = revision_for(lib_path("foo-bar"))
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", "1.0.0"
|
|
git "#{lib_path("foo-bar")}" do
|
|
gem "foo-bar"
|
|
end
|
|
G
|
|
|
|
bundle "install --path vendor/bundle"
|
|
|
|
update_git "foo", :path => lib_path("foo-bar")
|
|
revision2 = revision_for(lib_path("foo-bar"))
|
|
|
|
bundle "update"
|
|
bundle :clean
|
|
|
|
expect(out).to include("Removing foo-bar (#{revision[0..11]})")
|
|
|
|
expect(vendored_gems("gems/rack-1.0.0")).to exist
|
|
expect(vendored_gems("bundler/gems/foo-bar-#{revision[0..11]}")).not_to exist
|
|
expect(vendored_gems("bundler/gems/foo-bar-#{revision2[0..11]}")).to exist
|
|
|
|
expect(vendored_gems("specifications/rack-1.0.0.gemspec")).to exist
|
|
|
|
expect(vendored_gems("bin/rackup")).to exist
|
|
end
|
|
|
|
it "does not remove nested gems in a git repo" do
|
|
build_lib "activesupport", "3.0", :path => lib_path("rails/activesupport")
|
|
build_git "rails", "3.0", :path => lib_path("rails") do |s|
|
|
s.add_dependency "activesupport", "= 3.0"
|
|
end
|
|
revision = revision_for(lib_path("rails"))
|
|
|
|
gemfile <<-G
|
|
gem "activesupport", :git => "#{lib_path("rails")}", :ref => '#{revision}'
|
|
G
|
|
|
|
bundle "install --path vendor/bundle"
|
|
bundle :clean
|
|
expect(out).to include("")
|
|
|
|
expect(vendored_gems("bundler/gems/rails-#{revision[0..11]}")).to exist
|
|
end
|
|
|
|
it "does not remove git sources that are in without groups" do
|
|
build_git "foo", :path => lib_path("foo")
|
|
git_path = lib_path("foo")
|
|
revision = revision_for(git_path)
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", "1.0.0"
|
|
group :test do
|
|
git "#{git_path}", :ref => "#{revision}" do
|
|
gem "foo"
|
|
end
|
|
end
|
|
G
|
|
bundle "install --path vendor/bundle --without test"
|
|
|
|
bundle :clean
|
|
|
|
expect(out).to include("")
|
|
expect(vendored_gems("bundler/gems/foo-#{revision[0..11]}")).to exist
|
|
digest = Digest::SHA1.hexdigest(git_path.to_s)
|
|
expect(vendored_gems("cache/bundler/git/foo-#{digest}")).to_not exist
|
|
end
|
|
|
|
it "does not blow up when using without groups" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack"
|
|
|
|
group :development do
|
|
gem "foo"
|
|
end
|
|
G
|
|
|
|
bundle "install --path vendor/bundle --without development"
|
|
|
|
bundle :clean
|
|
expect(exitstatus).to eq(0) if exitstatus
|
|
end
|
|
|
|
it "displays an error when used without --path" do
|
|
install_gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack", "1.0.0"
|
|
G
|
|
|
|
bundle :clean
|
|
|
|
expect(exitstatus).to eq(1) if exitstatus
|
|
expect(out).to include("--force")
|
|
end
|
|
|
|
# handling bundle clean upgrade path from the pre's
|
|
it "removes .gem/.gemspec file even if there's no corresponding gem dir" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
gem "foo"
|
|
G
|
|
|
|
bundle "install --path vendor/bundle"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "foo"
|
|
G
|
|
bundle "install"
|
|
|
|
FileUtils.rm(vendored_gems("bin/rackup"))
|
|
FileUtils.rm_rf(vendored_gems("gems/thin-1.0"))
|
|
FileUtils.rm_rf(vendored_gems("gems/rack-1.0.0"))
|
|
|
|
bundle :clean
|
|
|
|
should_not_have_gems "thin-1.0", "rack-1.0"
|
|
should_have_gems "foo-1.0"
|
|
|
|
expect(vendored_gems("bin/rackup")).not_to exist
|
|
end
|
|
|
|
it "does not call clean automatically when using system gems" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
gem "rack"
|
|
G
|
|
bundle :install
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack"
|
|
G
|
|
bundle :install
|
|
|
|
sys_exec "gem list"
|
|
expect(out).to include("rack (1.0.0)")
|
|
expect(out).to include("thin (1.0)")
|
|
end
|
|
|
|
it "--clean should override the bundle setting on install" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
gem "rack"
|
|
G
|
|
bundle "install --path vendor/bundle --clean"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack"
|
|
G
|
|
bundle "install"
|
|
|
|
should_have_gems "rack-1.0.0"
|
|
should_not_have_gems "thin-1.0"
|
|
end
|
|
|
|
it "--clean should override the bundle setting on update" do
|
|
build_repo2
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo2}"
|
|
|
|
gem "foo"
|
|
G
|
|
bundle "install --path vendor/bundle --clean"
|
|
|
|
update_repo2 do
|
|
build_gem "foo", "1.0.1"
|
|
end
|
|
|
|
bundle "update"
|
|
|
|
should_have_gems "foo-1.0.1"
|
|
should_not_have_gems "foo-1.0"
|
|
end
|
|
|
|
it "does not clean automatically on --path" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
gem "rack"
|
|
G
|
|
bundle "install --path vendor/bundle"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack"
|
|
G
|
|
bundle "install"
|
|
|
|
should_have_gems "rack-1.0.0", "thin-1.0"
|
|
end
|
|
|
|
it "does not clean on bundle update with --path" do
|
|
build_repo2
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo2}"
|
|
|
|
gem "foo"
|
|
G
|
|
bundle "install --path vendor/bundle"
|
|
|
|
update_repo2 do
|
|
build_gem "foo", "1.0.1"
|
|
end
|
|
|
|
bundle :update
|
|
should_have_gems "foo-1.0", "foo-1.0.1"
|
|
end
|
|
|
|
it "does not clean on bundle update when using --system" do
|
|
build_repo2
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo2}"
|
|
|
|
gem "foo"
|
|
G
|
|
bundle "install"
|
|
|
|
update_repo2 do
|
|
build_gem "foo", "1.0.1"
|
|
end
|
|
bundle :update
|
|
|
|
sys_exec "gem list"
|
|
expect(out).to include("foo (1.0.1, 1.0)")
|
|
end
|
|
|
|
it "cleans system gems when --force is used" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "foo"
|
|
gem "rack"
|
|
G
|
|
bundle :install
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack"
|
|
G
|
|
bundle :install
|
|
bundle "clean --force"
|
|
|
|
expect(out).to include("Removing foo (1.0)")
|
|
sys_exec "gem list"
|
|
expect(out).not_to include("foo (1.0)")
|
|
expect(out).to include("rack (1.0.0)")
|
|
end
|
|
|
|
describe "when missing permissions" do
|
|
after do
|
|
FileUtils.chmod(0o755, default_bundle_path("cache"))
|
|
end
|
|
it "returns a helpful error message" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "foo"
|
|
gem "rack"
|
|
G
|
|
bundle :install
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "rack"
|
|
G
|
|
bundle :install
|
|
|
|
system_cache_path = default_bundle_path("cache")
|
|
FileUtils.chmod(0o500, system_cache_path)
|
|
|
|
bundle :clean, :force => true
|
|
|
|
expect(out).to include(system_gem_path.to_s)
|
|
expect(out).to include("grant write permissions")
|
|
|
|
sys_exec "gem list"
|
|
expect(out).to include("foo (1.0)")
|
|
expect(out).to include("rack (1.0.0)")
|
|
end
|
|
end
|
|
|
|
it "cleans git gems with a 7 length git revision" do
|
|
build_git "foo"
|
|
revision = revision_for(lib_path("foo-1.0"))
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "foo", :git => "#{lib_path("foo-1.0")}"
|
|
G
|
|
|
|
bundle "install --path vendor/bundle"
|
|
|
|
# mimic 7 length git revisions in Gemfile.lock
|
|
gemfile_lock = File.read(bundled_app("Gemfile.lock")).split("\n")
|
|
gemfile_lock.each_with_index do |line, index|
|
|
gemfile_lock[index] = line[0..(11 + 7)] if line.include?(" revision:")
|
|
end
|
|
File.open(bundled_app("Gemfile.lock"), "w") do |file|
|
|
file.print gemfile_lock.join("\n")
|
|
end
|
|
|
|
bundle "install --path vendor/bundle"
|
|
|
|
bundle :clean
|
|
|
|
expect(out).not_to include("Removing foo (1.0 #{revision[0..6]})")
|
|
|
|
expect(vendored_gems("bundler/gems/foo-1.0-#{revision[0..6]}")).to exist
|
|
end
|
|
|
|
it "when using --force on system gems, it doesn't remove binaries" do
|
|
build_repo2
|
|
update_repo2 do
|
|
build_gem "bindir" do |s|
|
|
s.bindir = "exe"
|
|
s.executables = "foo"
|
|
end
|
|
end
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo2}"
|
|
|
|
gem "bindir"
|
|
G
|
|
bundle :install
|
|
|
|
bundle "clean --force"
|
|
|
|
sys_exec "foo"
|
|
|
|
expect(exitstatus).to eq(0) if exitstatus
|
|
expect(out).to eq("1.0")
|
|
end
|
|
|
|
it "doesn't blow up on path gems without a .gempsec" do
|
|
relative_path = "vendor/private_gems/bar-1.0"
|
|
absolute_path = bundled_app(relative_path)
|
|
FileUtils.mkdir_p("#{absolute_path}/lib/bar")
|
|
File.open("#{absolute_path}/lib/bar/bar.rb", "wb") do |file|
|
|
file.puts "module Bar; end"
|
|
end
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "foo"
|
|
gem "bar", "1.0", :path => "#{relative_path}"
|
|
G
|
|
|
|
bundle "install --path vendor/bundle"
|
|
bundle :clean
|
|
|
|
expect(exitstatus).to eq(0) if exitstatus
|
|
end
|
|
|
|
it "doesn't remove gems in dry-run mode with path set" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
gem "foo"
|
|
G
|
|
|
|
bundle "install --path vendor/bundle --no-clean"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
G
|
|
|
|
bundle :install
|
|
|
|
bundle "clean --dry-run"
|
|
|
|
expect(out).not_to include("Removing foo (1.0)")
|
|
expect(out).to include("Would have removed foo (1.0)")
|
|
|
|
should_have_gems "thin-1.0", "rack-1.0.0", "foo-1.0"
|
|
|
|
expect(vendored_gems("bin/rackup")).to exist
|
|
end
|
|
|
|
it "doesn't remove gems in dry-run mode with no path set" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
gem "foo"
|
|
G
|
|
|
|
bundle "install --path vendor/bundle --no-clean"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
G
|
|
|
|
bundle :install
|
|
|
|
bundle "configuration --delete path"
|
|
|
|
bundle "clean --dry-run"
|
|
|
|
expect(out).not_to include("Removing foo (1.0)")
|
|
expect(out).to include("Would have removed foo (1.0)")
|
|
|
|
should_have_gems "thin-1.0", "rack-1.0.0", "foo-1.0"
|
|
|
|
expect(vendored_gems("bin/rackup")).to exist
|
|
end
|
|
|
|
it "doesn't store dry run as a config setting" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
gem "foo"
|
|
G
|
|
|
|
bundle "install --path vendor/bundle --no-clean"
|
|
bundle "config dry_run false"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
G
|
|
|
|
bundle :install
|
|
|
|
bundle "clean"
|
|
|
|
expect(out).to include("Removing foo (1.0)")
|
|
expect(out).not_to include("Would have removed foo (1.0)")
|
|
|
|
should_have_gems "thin-1.0", "rack-1.0.0"
|
|
should_not_have_gems "foo-1.0"
|
|
|
|
expect(vendored_gems("bin/rackup")).to exist
|
|
end
|
|
|
|
it "performs an automatic bundle install" do
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
gem "foo"
|
|
G
|
|
|
|
bundle "install --path vendor/bundle --no-clean"
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "thin"
|
|
gem "weakling"
|
|
G
|
|
|
|
bundle "config auto_install 1"
|
|
bundle :clean
|
|
expect(out).to include("Installing weakling 0.0.3")
|
|
should_have_gems "thin-1.0", "rack-1.0.0", "weakling-0.0.3"
|
|
should_not_have_gems "foo-1.0"
|
|
end
|
|
|
|
it "doesn't remove extensions artifacts from bundled git gems after clean", :ruby_repo, :rubygems => "2.2" do
|
|
build_git "very_simple_git_binary", &:add_c_extension
|
|
|
|
revision = revision_for(lib_path("very_simple_git_binary-1.0"))
|
|
|
|
gemfile <<-G
|
|
source "file://#{gem_repo1}"
|
|
|
|
gem "very_simple_git_binary", :git => "#{lib_path("very_simple_git_binary-1.0")}", :ref => "#{revision}"
|
|
G
|
|
|
|
bundle! "install --path vendor/bundle"
|
|
expect(vendored_gems("bundler/gems/extensions")).to exist
|
|
expect(vendored_gems("bundler/gems/very_simple_git_binary-1.0-#{revision[0..11]}")).to exist
|
|
|
|
bundle! :clean
|
|
expect(out).to eq("")
|
|
|
|
expect(vendored_gems("bundler/gems/extensions")).to exist
|
|
expect(vendored_gems("bundler/gems/very_simple_git_binary-1.0-#{revision[0..11]}")).to exist
|
|
end
|
|
end
|