mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
acb793b71c
These tests work on jruby, but the flags to the system command used to
detect whether `cmake` is present seem to be ignored on jruby and the
output is printed to screen instead of being sent to /dev/null. This
results in very verbose tests, like this:
```
$ rake TESTOPTS=--name=TestGemExtCmakeBuilder#test_self_build
(... warnings skipped ...)
Skipping `gem cert` tests on jruby.
Skipping Gem::Security tests on jruby.
Run options: --name=TestGemExtCmakeBuilder#test_self_build --seed 16839
# Running:
/home/deivid/Code/rubygems/test/rubygems/test_gem_ext_cmake_builder.rb:13: warning: system does not support options in JRuby yet: {:out=>"/dev/null", :err=>[:child, :out]}
Usage
cmake [options] <path-to-source>
cmake [options] <path-to-existing-build>
Specify a source directory to (re-)generate a build system for it in the
current working directory. Specify an existing build directory to
re-generate its build system.
Run 'cmake --help' for more information.
.
Finished in 0.387301s, 2.5820 runs/s, 20.6558 assertions/s.
1 runs, 8 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for Unit Tests to /home/deivid/Code/rubygems/coverage. 2258 / 8832 LOC (25.57%) covered.
```
By using `Open3`, we get the test output clean:
```
$ rake TESTOPTS=--name=TestGemExtCmakeBuilder#test_self_build
(... warnings skipped ...)
Skipping `gem cert` tests on jruby.
Skipping Gem::Security tests on jruby.
Run options: --name=TestGemExtCmakeBuilder#test_self_build --seed 22605
# Running:
.
Finished in 0.381959s, 2.6181 runs/s, 20.9446 assertions/s.
1 runs, 8 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for Unit Tests to /home/deivid/Code/rubygems/coverage. 2258 / 8832 LOC (25.57%) covered.
```
https://github.com/rubygems/rubygems/commit/531ce37ea3
88 lines
2.1 KiB
Ruby
88 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
require 'rubygems/test_case'
|
|
require 'rubygems/ext'
|
|
|
|
class TestGemExtCmakeBuilder < Gem::TestCase
|
|
|
|
def setup
|
|
super
|
|
|
|
# Details: https://github.com/rubygems/rubygems/issues/1270#issuecomment-177368340
|
|
skip "CmakeBuilder doesn't work on Windows." if Gem.win_platform?
|
|
|
|
_, status = Open3.capture2e('cmake')
|
|
|
|
skip 'cmake not present' unless status.success?
|
|
|
|
@ext = File.join @tempdir, 'ext'
|
|
@dest_path = File.join @tempdir, 'prefix'
|
|
|
|
FileUtils.mkdir_p @ext
|
|
FileUtils.mkdir_p @dest_path
|
|
end
|
|
|
|
def test_self_build
|
|
File.open File.join(@ext, 'CMakeLists.txt'), 'w' do |cmakelists|
|
|
cmakelists.write <<-EO_CMAKE
|
|
cmake_minimum_required(VERSION 2.6)
|
|
project(self_build NONE)
|
|
install (FILES test.txt DESTINATION bin)
|
|
EO_CMAKE
|
|
end
|
|
|
|
FileUtils.touch File.join(@ext, 'test.txt')
|
|
|
|
output = []
|
|
|
|
Dir.chdir @ext do
|
|
Gem::Ext::CmakeBuilder.build nil, @dest_path, output
|
|
end
|
|
|
|
output = output.join "\n"
|
|
|
|
assert_match \
|
|
%r{^cmake \. -DCMAKE_INSTALL_PREFIX=#{Regexp.escape @dest_path}}, output
|
|
assert_match %r{#{Regexp.escape @ext}}, output
|
|
assert_contains_make_command '', output
|
|
assert_contains_make_command 'install', output
|
|
assert_match %r{test\.txt}, output
|
|
end
|
|
|
|
def test_self_build_fail
|
|
output = []
|
|
|
|
error = assert_raises Gem::InstallError do
|
|
Dir.chdir @ext do
|
|
Gem::Ext::CmakeBuilder.build nil, @dest_path, output
|
|
end
|
|
end
|
|
|
|
output = output.join "\n"
|
|
|
|
shell_error_msg = %r{(CMake Error: .*)}
|
|
sh_prefix_cmake = "cmake . -DCMAKE_INSTALL_PREFIX="
|
|
|
|
assert_match 'cmake failed', error.message
|
|
|
|
assert_match %r{^#{sh_prefix_cmake}#{Regexp.escape @dest_path}}, output
|
|
assert_match %r{#{shell_error_msg}}, output
|
|
end
|
|
|
|
def test_self_build_has_makefile
|
|
File.open File.join(@ext, 'Makefile'), 'w' do |makefile|
|
|
makefile.puts "all:\n\t@echo ok\ninstall:\n\t@echo ok"
|
|
end
|
|
|
|
output = []
|
|
|
|
Dir.chdir @ext do
|
|
Gem::Ext::CmakeBuilder.build nil, @dest_path, output
|
|
end
|
|
|
|
output = output.join "\n"
|
|
|
|
assert_contains_make_command '', output
|
|
assert_contains_make_command 'install', output
|
|
end
|
|
|
|
end
|