mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
6325866421
https://rubyci.org/logs/rubyci.s3.amazonaws.com/rhel8/ruby-master/log/20201112T123004Z.fail.html.gz ``` 1) File.utime allows Time instances in the far future to set mtime and atime (but some filesystems limit it up to 2446-05-10) FAILED Expected [559444, 2446].include? 2038 to be truthy but was false /home/chkbuild/chkbuild/tmp/build/20201112T123004Z/ruby/spec/ruby/core/file/utime_spec.rb:80:in `block (4 levels) in <top (required)>' /home/chkbuild/chkbuild/tmp/build/20201112T123004Z/ruby/spec/ruby/core/file/utime_spec.rb:3:in `<top (required)>' ``` ``` $ touch foo $ ./miniruby -e 'time = Time.at(1<<44); File.utime(time, time, "foo")' $ ls -l foo -rw-r--r--. 1 mame wheel 0 Jan 19 2038 foo ```
89 lines
3.4 KiB
Ruby
89 lines
3.4 KiB
Ruby
require_relative '../../spec_helper'
|
|
|
|
describe "File.utime" do
|
|
|
|
before :all do
|
|
@time_is_float = platform_is :windows
|
|
end
|
|
|
|
before :each do
|
|
@atime = Time.now
|
|
@mtime = Time.now
|
|
@file1 = tmp("specs_file_utime1")
|
|
@file2 = tmp("specs_file_utime2")
|
|
touch @file1
|
|
touch @file2
|
|
end
|
|
|
|
after :each do
|
|
rm_r @file1, @file2
|
|
end
|
|
|
|
it "sets the access and modification time of each file" do
|
|
File.utime(@atime, @mtime, @file1, @file2)
|
|
if @time_is_float
|
|
File.atime(@file1).should be_close(@atime, 0.0001)
|
|
File.mtime(@file1).should be_close(@mtime, 0.0001)
|
|
File.atime(@file2).should be_close(@atime, 0.0001)
|
|
File.mtime(@file2).should be_close(@mtime, 0.0001)
|
|
else
|
|
File.atime(@file1).to_i.should be_close(@atime.to_i, TIME_TOLERANCE)
|
|
File.mtime(@file1).to_i.should be_close(@mtime.to_i, TIME_TOLERANCE)
|
|
File.atime(@file2).to_i.should be_close(@atime.to_i, TIME_TOLERANCE)
|
|
File.mtime(@file2).to_i.should be_close(@mtime.to_i, TIME_TOLERANCE)
|
|
end
|
|
end
|
|
|
|
it "uses the current times if two nil values are passed" do
|
|
tn = Time.now
|
|
File.utime(nil, nil, @file1, @file2)
|
|
if @time_is_float
|
|
File.atime(@file1).should be_close(tn, 0.050)
|
|
File.mtime(@file1).should be_close(tn, 0.050)
|
|
File.atime(@file2).should be_close(tn, 0.050)
|
|
File.mtime(@file2).should be_close(tn, 0.050)
|
|
else
|
|
File.atime(@file1).to_i.should be_close(Time.now.to_i, TIME_TOLERANCE)
|
|
File.mtime(@file1).to_i.should be_close(Time.now.to_i, TIME_TOLERANCE)
|
|
File.atime(@file2).to_i.should be_close(Time.now.to_i, TIME_TOLERANCE)
|
|
File.mtime(@file2).to_i.should be_close(Time.now.to_i, TIME_TOLERANCE)
|
|
end
|
|
end
|
|
|
|
it "accepts an object that has a #to_path method" do
|
|
File.utime(@atime, @mtime, mock_to_path(@file1), mock_to_path(@file2))
|
|
end
|
|
|
|
it "accepts numeric atime and mtime arguments" do
|
|
if @time_is_float
|
|
File.utime(@atime.to_f, @mtime.to_f, @file1, @file2)
|
|
File.atime(@file1).should be_close(@atime, 0.0001)
|
|
File.mtime(@file1).should be_close(@mtime, 0.0001)
|
|
File.atime(@file2).should be_close(@atime, 0.0001)
|
|
File.mtime(@file2).should be_close(@mtime, 0.0001)
|
|
else
|
|
File.utime(@atime.to_i, @mtime.to_i, @file1, @file2)
|
|
File.atime(@file1).to_i.should be_close(@atime.to_i, TIME_TOLERANCE)
|
|
File.mtime(@file1).to_i.should be_close(@mtime.to_i, TIME_TOLERANCE)
|
|
File.atime(@file2).to_i.should be_close(@atime.to_i, TIME_TOLERANCE)
|
|
File.mtime(@file2).to_i.should be_close(@mtime.to_i, TIME_TOLERANCE)
|
|
end
|
|
end
|
|
|
|
platform_is :linux do
|
|
platform_is wordsize: 64 do
|
|
it "allows Time instances in the far future to set mtime and atime (but some filesystems limit it up to 2446-05-10 or 2038-01-19)" do
|
|
# https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout#Inode_Timestamps
|
|
# "Therefore, timestamps should not overflow until May 2446."
|
|
# https://lwn.net/Articles/804382/
|
|
# "On-disk timestamps hitting the y2038 limit..."
|
|
# The problem seems to be being improved, but currently it actually fails on XFS on RHEL8
|
|
# https://rubyci.org/logs/rubyci.s3.amazonaws.com/rhel8/ruby-master/log/20201112T123004Z.fail.html.gz
|
|
time = Time.at(1<<44)
|
|
File.utime(time, time, @file1)
|
|
[559444, 2446, 2038].should.include? File.atime(@file1).year
|
|
[559444, 2446, 2038].should.include? File.mtime(@file1).year
|
|
end
|
|
end
|
|
end
|
|
end
|