mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
7585bc3187
Features:
- Add caller information to some deprecation messages to make them easier to fix [#7361](https://github.com/bundler/bundler/pull/7361)
- Reconcile `bundle cache` vs `bundle package` everywhere. Now in docs, CLI help and everywhere else `bundle cache` is the preferred version and `bundle package` remains as an alias [#7389](https://github.com/bundler/bundler/pull/7389)
- Display some basic `bundler` documentation together with ruby's RDoc based documentation [#7394](https://github.com/bundler/bundler/pull/7394)
Bugfixes:
- Fix typos deprecation message and upgrading docs [#7374](https://github.com/bundler/bundler/pull/7374)
- Deprecation warnings about `taint` usage on ruby 2.7 [#7385](https://github.com/bundler/bundler/pull/7385)
- Fix `--help` flag not correctly delegating to `man` when used with command aliases [#7388](https://github.com/bundler/bundler/pull/7388)
- `bundle add` should cache newly added gems if an application cache exists [#7393](https://github.com/bundler/bundler/pull/7393)
- Stop using an insecure folder as a "fallback home" when user home is not defined [#7416](https://github.com/bundler/bundler/pull/7416)
- Fix `bundler/inline` warning about `Bundler.root` redefinition [#7417](https://github.com/bundler/bundler/pull/7417)
351 lines
10 KiB
Ruby
351 lines
10 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "bundle cache" do
|
|
context "with --gemfile" do
|
|
it "finds the gemfile" do
|
|
gemfile bundled_app("NotGemfile"), <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem 'rack'
|
|
G
|
|
|
|
bundle "cache --gemfile=NotGemfile"
|
|
|
|
ENV["BUNDLE_GEMFILE"] = "NotGemfile"
|
|
expect(the_bundle).to include_gems "rack 1.0.0"
|
|
end
|
|
end
|
|
|
|
context "with --all" do
|
|
context "without a gemspec" do
|
|
it "caches all dependencies except bundler itself" do
|
|
gemfile <<-D
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem 'rack'
|
|
gem 'bundler'
|
|
D
|
|
|
|
bundle "config set cache_all true"
|
|
bundle :cache
|
|
|
|
expect(bundled_app("vendor/cache/rack-1.0.0.gem")).to exist
|
|
expect(bundled_app("vendor/cache/bundler-0.9.gem")).to_not exist
|
|
end
|
|
end
|
|
|
|
context "with a gemspec" do
|
|
context "that has the same name as the gem" do
|
|
before do
|
|
File.open(bundled_app("mygem.gemspec"), "w") do |f|
|
|
f.write <<-G
|
|
Gem::Specification.new do |s|
|
|
s.name = "mygem"
|
|
s.version = "0.1.1"
|
|
s.summary = ""
|
|
s.authors = ["gem author"]
|
|
s.add_development_dependency "nokogiri", "=1.4.2"
|
|
end
|
|
G
|
|
end
|
|
end
|
|
|
|
it "caches all dependencies except bundler and the gemspec specified gem" do
|
|
gemfile <<-D
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem 'rack'
|
|
gemspec
|
|
D
|
|
|
|
bundle "config set cache_all true"
|
|
bundle! :cache
|
|
|
|
expect(bundled_app("vendor/cache/rack-1.0.0.gem")).to exist
|
|
expect(bundled_app("vendor/cache/nokogiri-1.4.2.gem")).to exist
|
|
expect(bundled_app("vendor/cache/mygem-0.1.1.gem")).to_not exist
|
|
expect(bundled_app("vendor/cache/bundler-0.9.gem")).to_not exist
|
|
end
|
|
end
|
|
|
|
context "that has a different name as the gem" do
|
|
before do
|
|
File.open(bundled_app("mygem_diffname.gemspec"), "w") do |f|
|
|
f.write <<-G
|
|
Gem::Specification.new do |s|
|
|
s.name = "mygem"
|
|
s.version = "0.1.1"
|
|
s.summary = ""
|
|
s.authors = ["gem author"]
|
|
s.add_development_dependency "nokogiri", "=1.4.2"
|
|
end
|
|
G
|
|
end
|
|
end
|
|
|
|
it "caches all dependencies except bundler and the gemspec specified gem" do
|
|
gemfile <<-D
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem 'rack'
|
|
gemspec
|
|
D
|
|
|
|
bundle "config set cache_all true"
|
|
bundle! :cache
|
|
|
|
expect(bundled_app("vendor/cache/rack-1.0.0.gem")).to exist
|
|
expect(bundled_app("vendor/cache/nokogiri-1.4.2.gem")).to exist
|
|
expect(bundled_app("vendor/cache/mygem-0.1.1.gem")).to_not exist
|
|
expect(bundled_app("vendor/cache/bundler-0.9.gem")).to_not exist
|
|
end
|
|
end
|
|
end
|
|
|
|
context "with multiple gemspecs" do
|
|
before do
|
|
File.open(bundled_app("mygem.gemspec"), "w") do |f|
|
|
f.write <<-G
|
|
Gem::Specification.new do |s|
|
|
s.name = "mygem"
|
|
s.version = "0.1.1"
|
|
s.summary = ""
|
|
s.authors = ["gem author"]
|
|
s.add_development_dependency "nokogiri", "=1.4.2"
|
|
end
|
|
G
|
|
end
|
|
File.open(bundled_app("mygem_client.gemspec"), "w") do |f|
|
|
f.write <<-G
|
|
Gem::Specification.new do |s|
|
|
s.name = "mygem_test"
|
|
s.version = "0.1.1"
|
|
s.summary = ""
|
|
s.authors = ["gem author"]
|
|
s.add_development_dependency "weakling", "=0.0.3"
|
|
end
|
|
G
|
|
end
|
|
end
|
|
|
|
it "caches all dependencies except bundler and the gemspec specified gems" do
|
|
gemfile <<-D
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem 'rack'
|
|
gemspec :name => 'mygem'
|
|
gemspec :name => 'mygem_test'
|
|
D
|
|
|
|
bundle "config set cache_all true"
|
|
bundle! :cache
|
|
|
|
expect(bundled_app("vendor/cache/rack-1.0.0.gem")).to exist
|
|
expect(bundled_app("vendor/cache/nokogiri-1.4.2.gem")).to exist
|
|
expect(bundled_app("vendor/cache/weakling-0.0.3.gem")).to exist
|
|
expect(bundled_app("vendor/cache/mygem-0.1.1.gem")).to_not exist
|
|
expect(bundled_app("vendor/cache/mygem_test-0.1.1.gem")).to_not exist
|
|
expect(bundled_app("vendor/cache/bundler-0.9.gem")).to_not exist
|
|
end
|
|
end
|
|
end
|
|
|
|
context "with --path", :bundler => "< 3" do
|
|
it "sets root directory for gems" do
|
|
gemfile <<-D
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem 'rack'
|
|
D
|
|
|
|
bundle! :cache, forgotten_command_line_options(:path => bundled_app("test"))
|
|
|
|
expect(the_bundle).to include_gems "rack 1.0.0"
|
|
expect(bundled_app("test/vendor/cache/")).to exist
|
|
end
|
|
end
|
|
|
|
context "with --no-install" do
|
|
it "puts the gems in vendor/cache but does not install them" do
|
|
gemfile <<-D
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem 'rack'
|
|
D
|
|
|
|
bundle! "cache --no-install"
|
|
|
|
expect(the_bundle).not_to include_gems "rack 1.0.0"
|
|
expect(bundled_app("vendor/cache/rack-1.0.0.gem")).to exist
|
|
end
|
|
|
|
it "does not prevent installing gems with bundle install" do
|
|
gemfile <<-D
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem 'rack'
|
|
D
|
|
|
|
bundle! "cache --no-install"
|
|
bundle! "install"
|
|
|
|
expect(the_bundle).to include_gems "rack 1.0.0"
|
|
end
|
|
|
|
it "does not prevent installing gems with bundle update" do
|
|
gemfile <<-D
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "rack", "1.0.0"
|
|
D
|
|
|
|
bundle! "cache --no-install"
|
|
bundle! "update --all"
|
|
|
|
expect(the_bundle).to include_gems "rack 1.0.0"
|
|
end
|
|
end
|
|
|
|
context "with --all-platforms" do
|
|
it "puts the gems in vendor/cache even for other rubies" do
|
|
gemfile <<-D
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem 'rack', :platforms => :ruby_19
|
|
D
|
|
|
|
bundle "cache --all-platforms"
|
|
expect(bundled_app("vendor/cache/rack-1.0.0.gem")).to exist
|
|
end
|
|
|
|
it "does not attempt to install gems in without groups" do
|
|
build_repo4 do
|
|
build_gem "uninstallable", "2.0" do |s|
|
|
s.add_development_dependency "rake"
|
|
s.extensions << "Rakefile"
|
|
s.write "Rakefile", "task(:default) { raise 'CANNOT INSTALL' }"
|
|
end
|
|
end
|
|
|
|
install_gemfile! <<-G, forgotten_command_line_options(:without => "wo")
|
|
source "file:#{gem_repo1}"
|
|
gem "rack"
|
|
group :wo do
|
|
gem "weakling"
|
|
gem "uninstallable", :source => "file:#{gem_repo4}"
|
|
end
|
|
G
|
|
|
|
bundle! :cache, "all-platforms" => true
|
|
expect(bundled_app("vendor/cache/weakling-0.0.3.gem")).to exist
|
|
expect(bundled_app("vendor/cache/uninstallable-2.0.gem")).to exist
|
|
expect(the_bundle).to include_gem "rack 1.0"
|
|
expect(the_bundle).not_to include_gems "weakling", "uninstallable"
|
|
|
|
bundle! :install, forgotten_command_line_options(:without => "wo")
|
|
expect(the_bundle).to include_gem "rack 1.0"
|
|
expect(the_bundle).not_to include_gems "weakling", "uninstallable"
|
|
end
|
|
end
|
|
|
|
context "with --frozen" do
|
|
before do
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "rack"
|
|
G
|
|
bundle "install"
|
|
end
|
|
|
|
subject { bundle :cache, forgotten_command_line_options(:frozen => true) }
|
|
|
|
it "tries to install with frozen" do
|
|
bundle! "config set deployment true"
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "rack"
|
|
gem "rack-obama"
|
|
G
|
|
subject
|
|
expect(exitstatus).to eq(16) if exitstatus
|
|
expect(err).to include("deployment mode")
|
|
expect(err).to include("You have added to the Gemfile")
|
|
expect(err).to include("* rack-obama")
|
|
bundle "env"
|
|
expect(out).to include("frozen").or include("deployment")
|
|
end
|
|
end
|
|
end
|
|
|
|
RSpec.describe "bundle install with gem sources" do
|
|
describe "when cached and locked" do
|
|
it "does not hit the remote at all" do
|
|
build_repo2
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo2)}"
|
|
gem "rack"
|
|
G
|
|
|
|
bundle :cache
|
|
simulate_new_machine
|
|
FileUtils.rm_rf gem_repo2
|
|
|
|
bundle "install --local"
|
|
expect(the_bundle).to include_gems "rack 1.0.0"
|
|
end
|
|
|
|
it "does not hit the remote at all" do
|
|
build_repo2
|
|
install_gemfile! <<-G
|
|
source "#{file_uri_for(gem_repo2)}"
|
|
gem "rack"
|
|
G
|
|
|
|
bundle! :cache
|
|
simulate_new_machine
|
|
FileUtils.rm_rf gem_repo2
|
|
|
|
bundle! :install, forgotten_command_line_options(:deployment => true, :path => "vendor/bundle")
|
|
expect(the_bundle).to include_gems "rack 1.0.0"
|
|
end
|
|
|
|
it "does not reinstall already-installed gems" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "rack"
|
|
G
|
|
bundle :cache
|
|
|
|
build_gem "rack", "1.0.0", :path => bundled_app("vendor/cache") do |s|
|
|
s.write "lib/rack.rb", "raise 'omg'"
|
|
end
|
|
|
|
bundle :install
|
|
expect(err).to be_empty
|
|
expect(the_bundle).to include_gems "rack 1.0"
|
|
end
|
|
|
|
it "ignores cached gems for the wrong platform" do
|
|
simulate_platform "java" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "platform_specific"
|
|
G
|
|
bundle :cache
|
|
end
|
|
|
|
simulate_new_machine
|
|
|
|
simulate_platform "ruby" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "platform_specific"
|
|
G
|
|
run "require 'platform_specific' ; puts PLATFORM_SPECIFIC"
|
|
expect(out).to eq("1.0.0 RUBY")
|
|
end
|
|
end
|
|
|
|
it "does not update the cache if --no-cache is passed" do
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "rack"
|
|
G
|
|
bundled_app("vendor/cache").mkpath
|
|
expect(bundled_app("vendor/cache").children).to be_empty
|
|
|
|
bundle "install --no-cache"
|
|
expect(bundled_app("vendor/cache").children).to be_empty
|
|
end
|
|
end
|
|
end
|