1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
ruby--ruby/lib/irb/cmd
Stan Lo 44c1316293 [ruby/irb] Centralize coloring control (https://github.com/ruby/irb/pull/374)
* Use colorable: argument as the only coloring control

* Centalize color controling logic at Color.colorable?

There are 2 requirements for coloring output:

1. It's supported on the platform
2. The user wants it: `IRB.conf[:USE_COLORIZE] == true`

Right now we check 1 and 2 separately whenever we colorize things.
But it's error-prone because while 1 is the default of `colorable`
parameter, 2 always need to manually checked. When 2 is overlooked, it
causes issues like https://github.com/ruby/irb/pull/362

And there's 0 case where we may want to colorize even when the user
disables it. So I think we should merge 2 into `Color.colorable?` so it
can be automatically picked up.

* Add tests for all inspect modes

* Simplify inspectors' coloring logic

* Replace use_colorize? with Color.colorable?

* Remove Context#use_colorize cause it's redundant

https://github.com/ruby/irb/commit/1c53023ac4
2022-06-28 22:30:42 +09:00
..
chws.rb
fork.rb
help.rb
info.rb
load.rb
ls.rb [ruby/irb] Centralize coloring control (https://github.com/ruby/irb/pull/374) 2022-06-28 22:30:42 +09:00
measure.rb
nop.rb [ruby/irb] Centralize coloring control (https://github.com/ruby/irb/pull/374) 2022-06-28 22:30:42 +09:00
pushws.rb
show_source.rb [ruby/irb] Centralize coloring control (https://github.com/ruby/irb/pull/374) 2022-06-28 22:30:42 +09:00
subirb.rb
whereami.rb