mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
b957c3dbcb
This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb".
The two files are a helper for tests, not test files. However, a file
starting with "test_" prefix is handled as a test file directly loaded
by test-unit because Rakefile specifies:
```
t.test_files = FileList['test/**/test_*.rb']
```
Directly loading test/rubygems/test_utilities.rb caused "uninitialized
constant Gem::TestCase". This issue was fixed by
59c6820971, but the fix caused a
"circular require" warning because test_utilities.rb and test_case.rb
are now requiring each other.
Anyway, adding "test_" prefix to a test helper file is confusing, so
this changeset reverts the fix and solve the issue by renaming them.
https://github.com/rubygems/rubygems/commit/6460e018df
79 lines
2.5 KiB
Ruby
79 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
require_relative 'helper'
|
|
require 'rubygems/ext'
|
|
|
|
class TestGemExtConfigureBuilder < Gem::TestCase
|
|
def setup
|
|
super
|
|
|
|
@makefile_body =
|
|
"clean:\n\t@echo ok\nall:\n\t@echo ok\ninstall:\n\t@echo ok"
|
|
|
|
@ext = File.join @tempdir, 'ext'
|
|
@dest_path = File.join @tempdir, 'prefix'
|
|
|
|
FileUtils.mkdir_p @ext
|
|
FileUtils.mkdir_p @dest_path
|
|
end
|
|
|
|
def test_self_build
|
|
pend("test_self_build skipped on MS Windows (VC++)") if vc_windows?
|
|
|
|
File.open File.join(@ext, './configure'), 'w' do |configure|
|
|
configure.puts "#!/bin/sh\necho \"#{@makefile_body}\" > Makefile"
|
|
end
|
|
|
|
output = []
|
|
|
|
Gem::Ext::ConfigureBuilder.build nil, @dest_path, output, [], nil, @ext
|
|
|
|
assert_match(/^current directory:/, output.shift)
|
|
assert_equal "sh ./configure --prefix\\=#{@dest_path}", output.shift
|
|
assert_equal "", output.shift
|
|
assert_match(/^current directory:/, output.shift)
|
|
assert_contains_make_command 'clean', output.shift
|
|
assert_match(/^ok$/m, output.shift)
|
|
assert_match(/^current directory:/, output.shift)
|
|
assert_contains_make_command '', output.shift
|
|
assert_match(/^ok$/m, output.shift)
|
|
assert_match(/^current directory:/, output.shift)
|
|
assert_contains_make_command 'install', output.shift
|
|
assert_match(/^ok$/m, output.shift)
|
|
end
|
|
|
|
def test_self_build_fail
|
|
pend("test_self_build_fail skipped on MS Windows (VC++)") if vc_windows?
|
|
output = []
|
|
|
|
error = assert_raise Gem::InstallError do
|
|
Gem::Ext::ConfigureBuilder.build nil, @dest_path, output, [], nil, @ext
|
|
end
|
|
|
|
shell_error_msg = %r{(\./configure: .*)|((?:[Cc]an't|cannot) open '?\./configure'?(?:: No such file or directory)?)}
|
|
sh_prefix_configure = "sh ./configure --prefix\\="
|
|
|
|
assert_match 'configure failed', error.message
|
|
|
|
assert_match(/^current directory:/, output.shift)
|
|
assert_equal "#{sh_prefix_configure}#{@dest_path}", output.shift
|
|
assert_match %r{#{shell_error_msg}}, output.shift
|
|
assert_equal true, output.empty?
|
|
end
|
|
|
|
def test_self_build_has_makefile
|
|
if vc_windows? && !nmake_found?
|
|
pend("test_self_build_has_makefile skipped - nmake not found")
|
|
end
|
|
|
|
File.open File.join(@ext, 'Makefile'), 'w' do |makefile|
|
|
makefile.puts @makefile_body
|
|
end
|
|
|
|
output = []
|
|
Gem::Ext::ConfigureBuilder.build nil, @dest_path, output, [], nil, @ext
|
|
|
|
assert_contains_make_command 'clean', output[1]
|
|
assert_contains_make_command '', output[4]
|
|
assert_contains_make_command 'install', output[7]
|
|
end
|
|
end
|