mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
b957c3dbcb
This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb".
The two files are a helper for tests, not test files. However, a file
starting with "test_" prefix is handled as a test file directly loaded
by test-unit because Rakefile specifies:
```
t.test_files = FileList['test/**/test_*.rb']
```
Directly loading test/rubygems/test_utilities.rb caused "uninitialized
constant Gem::TestCase". This issue was fixed by
59c6820971, but the fix caused a
"circular require" warning because test_utilities.rb and test_case.rb
are now requiring each other.
Anyway, adding "test_" prefix to a test helper file is confusing, so
this changeset reverts the fix and solve the issue by renaming them.
https://github.com/rubygems/rubygems/commit/6460e018df
42 lines
834 B
Ruby
42 lines
834 B
Ruby
# frozen_string_literal: true
|
|
|
|
require_relative "helper"
|
|
require "rubygems/validator"
|
|
|
|
class TestGemValidator < Gem::TestCase
|
|
def setup
|
|
super
|
|
|
|
@validator = Gem::Validator.new
|
|
end
|
|
|
|
def test_alien
|
|
@spec = quick_gem 'a' do |s|
|
|
s.files = %w[lib/a.rb lib/b.rb]
|
|
end
|
|
|
|
util_build_gem @spec
|
|
|
|
FileUtils.rm File.join(@spec.gem_dir, 'lib/b.rb')
|
|
FileUtils.touch File.join(@spec.gem_dir, 'lib/c.rb')
|
|
|
|
alien = @validator.alien 'a'
|
|
|
|
expected = {
|
|
@spec.file_name => [
|
|
Gem::Validator::ErrorData.new('lib/b.rb', 'Missing file'),
|
|
Gem::Validator::ErrorData.new('lib/c.rb', 'Extra file'),
|
|
],
|
|
}
|
|
|
|
assert_equal expected, alien
|
|
end
|
|
|
|
def test_alien_default
|
|
new_default_spec 'c', 1, nil, 'lib/c.rb'
|
|
|
|
alien = @validator.alien 'c'
|
|
|
|
assert_empty alien
|
|
end
|
|
end
|