mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
58325daae3
This modifies the following String methods to return String instances instead of subclass instances: * String#* * String#capitalize * String#center * String#chomp * String#chop * String#delete * String#delete_prefix * String#delete_suffix * String#downcase * String#dump * String#each/#each_line * String#gsub * String#ljust * String#lstrip * String#partition * String#reverse * String#rjust * String#rpartition * String#rstrip * String#scrub * String#slice! * String#slice/#[] * String#split * String#squeeze * String#strip * String#sub * String#succ/#next * String#swapcase * String#tr * String#tr_s * String#upcase This also fixes a bug in String#swapcase where it would return the receiver instead of a copy of the receiver if the receiver was the empty string. Some string methods were left to return subclass instances: * String#+@ * String#-@ Both of these methods will return the receiver (subclass instance) in some cases, so it is best to keep the returned class consistent. Fixes [#10845]
80 lines
2.7 KiB
Ruby
80 lines
2.7 KiB
Ruby
describe :string_times, shared: true do
|
|
class MyString < String; end
|
|
|
|
it "returns a new string containing count copies of self" do
|
|
@object.call("cool", 0).should == ""
|
|
@object.call("cool", 1).should == "cool"
|
|
@object.call("cool", 3).should == "coolcoolcool"
|
|
end
|
|
|
|
it "tries to convert the given argument to an integer using to_int" do
|
|
@object.call("cool", 3.1).should == "coolcoolcool"
|
|
@object.call("a", 3.999).should == "aaa"
|
|
|
|
a = mock('4')
|
|
a.should_receive(:to_int).and_return(4)
|
|
|
|
@object.call("a", a).should == "aaaa"
|
|
end
|
|
|
|
it "raises an ArgumentError when given integer is negative" do
|
|
-> { @object.call("cool", -3) }.should raise_error(ArgumentError)
|
|
-> { @object.call("cool", -3.14) }.should raise_error(ArgumentError)
|
|
-> { @object.call("cool", min_long) }.should raise_error(ArgumentError)
|
|
end
|
|
|
|
it "raises a RangeError when given integer is a Bignum" do
|
|
-> { @object.call("cool", 999999999999999999999) }.should raise_error(RangeError)
|
|
-> { @object.call("", 999999999999999999999) }.should raise_error(RangeError)
|
|
end
|
|
|
|
it "works with huge long values when string is empty" do
|
|
@object.call("", max_long).should == ""
|
|
end
|
|
|
|
ruby_version_is ''...'3.0' do
|
|
it "returns subclass instances" do
|
|
@object.call(MyString.new("cool"), 0).should be_an_instance_of(MyString)
|
|
@object.call(MyString.new("cool"), 1).should be_an_instance_of(MyString)
|
|
@object.call(MyString.new("cool"), 2).should be_an_instance_of(MyString)
|
|
end
|
|
end
|
|
|
|
ruby_version_is '3.0' do
|
|
it "returns String instances" do
|
|
@object.call(MyString.new("cool"), 0).should be_an_instance_of(String)
|
|
@object.call(MyString.new("cool"), 1).should be_an_instance_of(String)
|
|
@object.call(MyString.new("cool"), 2).should be_an_instance_of(String)
|
|
end
|
|
end
|
|
|
|
ruby_version_is ''...'2.7' do
|
|
it "always taints the result when self is tainted" do
|
|
["", "OK", MyString.new(""), MyString.new("OK")].each do |str|
|
|
str.taint
|
|
|
|
[0, 1, 2].each do |arg|
|
|
@object.call(str, arg).should.tainted?
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
it "returns a String in the same encoding as self" do
|
|
str = "\xE3\x81\x82".force_encoding Encoding::UTF_8
|
|
result = @object.call(str, 2)
|
|
result.encoding.should equal(Encoding::UTF_8)
|
|
end
|
|
|
|
platform_is wordsize: 32 do
|
|
it "raises an ArgumentError if the length of the resulting string doesn't fit into a long" do
|
|
-> { @object.call("abc", (2 ** 31) - 1) }.should raise_error(ArgumentError)
|
|
end
|
|
end
|
|
|
|
platform_is wordsize: 64 do
|
|
it "raises an ArgumentError if the length of the resulting string doesn't fit into a long" do
|
|
-> { @object.call("abc", (2 ** 63) - 1) }.should raise_error(ArgumentError)
|
|
end
|
|
end
|
|
end
|