mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
597ce7966c
[Bug #19004] `Complex.polar` handles complex singular `abs` argument `Complex.polar` accepts Complex values as arguments for the polar form as long as the value of the complex has no imaginary part (ie it is 'real'). In `f_complex_polar` this is handled by extracting the real part of the arguments. However in the case `polar` is called with only a single argument, the absolute value (abs), then the Complex is created without applying a check on the type of abs, meaning it is possible to create a Complex where the real part is itself an instance of a Complex. This change removes the short circuit for the single argument case meaning the real part extraction is performed correctly (by f_complex_polar). Also adds an example to `spec/ruby/core/complex/polar_spec.rb` to check that the real part of a complex argument is correctly extracted and used in the resulting Complex real and imaginary parts. --- complex.c | 13 ++++++------- spec/ruby/core/complex/polar_spec.rb | 16 ++++++++++++++++ 2 files changed, 22 insertions(+), 7 deletions(-)
43 lines
1.5 KiB
Ruby
43 lines
1.5 KiB
Ruby
require_relative '../../spec_helper'
|
|
|
|
describe "Complex.polar" do
|
|
it "returns a complex number in terms of radius and angle" do
|
|
Complex.polar(50, 60).should be_close(Complex(-47.6206490207578, -15.2405310551108), TOLERANCE)
|
|
Complex.polar(-10, -20).should be_close(Complex(-4.08082061813392, 9.12945250727628), TOLERANCE)
|
|
end
|
|
|
|
it "raises a TypeError when given non real arguments" do
|
|
->{ Complex.polar(nil) }.should raise_error(TypeError)
|
|
->{ Complex.polar(nil, nil) }.should raise_error(TypeError)
|
|
end
|
|
|
|
ruby_bug "#19004", ""..."3.2" do
|
|
it "computes the real values of the real & imaginary parts from the polar form" do
|
|
a = Complex.polar(1.0+0.0i, Math::PI/2+0.0i)
|
|
a.real.should be_close(0.0, TOLERANCE)
|
|
a.imag.should be_close(1.0, TOLERANCE)
|
|
a.real.real?.should be_true
|
|
a.imag.real?.should be_true
|
|
|
|
b = Complex.polar(1+0.0i)
|
|
b.real.should be_close(1.0, TOLERANCE)
|
|
b.imag.should be_close(0.0, TOLERANCE)
|
|
b.real.real?.should be_true
|
|
b.imag.real?.should be_true
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "Complex#polar" do
|
|
it "returns the absolute value and the argument" do
|
|
a = Complex(3, 4)
|
|
a.polar.size.should == 2
|
|
a.polar.first.should == 5.0
|
|
a.polar.last.should be_close(0.927295218001612, TOLERANCE)
|
|
|
|
b = Complex(-3.5, 4.7)
|
|
b.polar.size.should == 2
|
|
b.polar.first.should be_close(5.86003412959345, TOLERANCE)
|
|
b.polar.last.should be_close(2.21088447955664, TOLERANCE)
|
|
end
|
|
end
|