mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
6a65f2b1e4
All normal Ruby IO methods (IO#read, IO#gets, IO#write, ...) are all capable of appearing to be "blocking" when presented with a file description with the O_NONBLOCK flag set; so there is little risk of incompatibility within Ruby-using programs. The biggest compatibility risk is when spawning external programs. As a result, stdin, stdout, and stderr are now always made blocking before exec-family calls. This change will make an event-oriented MJIT usable if it is waiting on pipes on POSIX_like platforms. It is ALSO necessary to take advantage of (proposed lightweight concurrency (aka "auto-Fiber") or any similar proposal for network concurrency: https://bugs.ruby-lang.org/issues/13618 Named-pipe (FIFO) are NOT yet non-blocking by default since they are rarely-used and may introduce compatibility problems and extra syscall overhead for a common path. Please revert this commit if there are problems and if I am afk since I am afk a lot, lately. [ruby-core:89950] [Bug #14968] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
56 lines
1.6 KiB
Ruby
56 lines
1.6 KiB
Ruby
require_relative '../spec_helper'
|
|
require_relative '../fixtures/classes'
|
|
|
|
describe 'Socket#connect' do
|
|
SocketSpecs.each_ip_protocol do |family, ip_address|
|
|
before do
|
|
@server = Socket.new(family, :STREAM)
|
|
@client = Socket.new(family, :STREAM)
|
|
|
|
@server.bind(Socket.sockaddr_in(0, ip_address))
|
|
end
|
|
|
|
after do
|
|
@client.close
|
|
@server.close
|
|
end
|
|
|
|
it 'returns 0 when connected successfully using a String' do
|
|
@server.listen(1)
|
|
|
|
@client.connect(@server.getsockname).should == 0
|
|
end
|
|
|
|
it 'returns 0 when connected successfully using an Addrinfo' do
|
|
@server.listen(1)
|
|
|
|
@client.connect(@server.connect_address).should == 0
|
|
end
|
|
|
|
it 'raises Errno::EISCONN when already connected' do
|
|
@server.listen(1)
|
|
|
|
@client.connect(@server.getsockname).should == 0
|
|
|
|
lambda {
|
|
@client.connect(@server.getsockname)
|
|
|
|
# A second call needed if non-blocking sockets become default
|
|
# XXX honestly I don't expect any real code to care about this spec
|
|
# as it's too implementation-dependent and checking for connect()
|
|
# errors is futile anyways because of TOCTOU
|
|
@client.connect(@server.getsockname)
|
|
}.should raise_error(Errno::EISCONN)
|
|
end
|
|
|
|
platform_is_not :darwin do
|
|
it 'raises Errno::ECONNREFUSED or Errno::ETIMEDOUT when the connection failed' do
|
|
begin
|
|
@client.connect(@server.getsockname)
|
|
rescue => e
|
|
[Errno::ECONNREFUSED, Errno::ETIMEDOUT].include?(e.class).should == true
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|