mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
58325daae3
This modifies the following String methods to return String instances instead of subclass instances: * String#* * String#capitalize * String#center * String#chomp * String#chop * String#delete * String#delete_prefix * String#delete_suffix * String#downcase * String#dump * String#each/#each_line * String#gsub * String#ljust * String#lstrip * String#partition * String#reverse * String#rjust * String#rpartition * String#rstrip * String#scrub * String#slice! * String#slice/#[] * String#split * String#squeeze * String#strip * String#sub * String#succ/#next * String#swapcase * String#tr * String#tr_s * String#upcase This also fixes a bug in String#swapcase where it would return the receiver instead of a copy of the receiver if the receiver was the empty string. Some string methods were left to return subclass instances: * String#+@ * String#-@ Both of these methods will return the receiver (subclass instance) in some cases, so it is best to keep the returned class consistent. Fixes [#10845]
47 lines
1.2 KiB
Ruby
47 lines
1.2 KiB
Ruby
# frozen_string_literal: false
|
|
require 'test/unit'
|
|
require "-test-/string"
|
|
|
|
class Test_StringEllipsize < Test::Unit::TestCase
|
|
def setup
|
|
@foobar = Bug::String.new("foobar")
|
|
end
|
|
|
|
def assert_equal_with_class(expected, result, *rest)
|
|
assert_equal(expected.encoding, result.encoding, *rest)
|
|
assert_equal(expected, result, result.encoding.name)
|
|
assert_instance_of(String, result, *rest)
|
|
end
|
|
|
|
def test_longer
|
|
assert_equal_with_class("", @foobar.ellipsize(0))
|
|
assert_equal_with_class(".", @foobar.ellipsize(1))
|
|
assert_equal_with_class("..", @foobar.ellipsize(2))
|
|
assert_equal_with_class("...", @foobar.ellipsize(3))
|
|
assert_equal_with_class("f...", @foobar.ellipsize(4))
|
|
assert_equal_with_class("fo...", @foobar.ellipsize(5))
|
|
end
|
|
|
|
def test_shorter
|
|
assert_same(@foobar, @foobar.ellipsize(6))
|
|
assert_same(@foobar, @foobar.ellipsize(7))
|
|
end
|
|
|
|
def test_negative_length
|
|
assert_raise(IndexError) {@foobar.ellipsize(-1)}
|
|
end
|
|
|
|
def test_nonascii
|
|
a = "\u3042"
|
|
Encoding.list.each do |enc|
|
|
next if enc.dummy?
|
|
begin
|
|
s = a.encode(enc)
|
|
e = "...".encode(enc)
|
|
rescue
|
|
else
|
|
assert_equal_with_class(s*12+e, Bug::String.new(s*20).ellipsize(15))
|
|
end
|
|
end
|
|
end
|
|
end
|