mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
c55b5f1062
As far as I could see, `Gem::Resolver::APISpecification` objects are supposed to be immutable. If my guessing is correct, then we can cache and reuse its instances for performance. At least, `rake` passes on my machine. Before this change: ``` $ time ruby -I lib bin/gem install --no-doc aws-sdk Successfully installed aws-sdk-3.0.1 1 gem installed real 0m37.104s user 0m36.952s sys 0m0.333s ``` After this change: ``` $ time ruby -I lib bin/gem install --no-doc aws-sdk Successfully installed aws-sdk-3.0.1 1 gem installed real 0m23.905s user 0m23.740s sys 0m0.365s ``` https://github.com/rubygems/rubygems/commit/7e8fbba85c
99 lines
2.5 KiB
Ruby
99 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
##
|
|
# Represents a specification retrieved via the rubygems.org API.
|
|
#
|
|
# This is used to avoid loading the full Specification object when all we need
|
|
# is the name, version, and dependencies.
|
|
|
|
class Gem::Resolver::APISpecification < Gem::Resolver::Specification
|
|
##
|
|
# We assume that all instances of this class are immutable;
|
|
# so avoid duplicated generation for performance.
|
|
@@cache = {}
|
|
def self.new(set, api_data)
|
|
cache_key = [set, api_data]
|
|
cache = @@cache[cache_key]
|
|
return cache if cache
|
|
@@cache[cache_key] = super
|
|
end
|
|
|
|
##
|
|
# Creates an APISpecification for the given +set+ from the rubygems.org
|
|
# +api_data+.
|
|
#
|
|
# See https://guides.rubygems.org/rubygems-org-api/#misc_methods for the
|
|
# format of the +api_data+.
|
|
|
|
def initialize(set, api_data)
|
|
super()
|
|
|
|
@set = set
|
|
@name = api_data[:name]
|
|
@version = Gem::Version.new(api_data[:number]).freeze
|
|
@platform = Gem::Platform.new(api_data[:platform]).freeze
|
|
@original_platform = api_data[:platform].freeze
|
|
@dependencies = api_data[:dependencies].map do |name, ver|
|
|
Gem::Dependency.new(name, ver.split(/\s*,\s*/)).freeze
|
|
end.freeze
|
|
end
|
|
|
|
def ==(other) # :nodoc:
|
|
self.class === other and
|
|
@set == other.set and
|
|
@name == other.name and
|
|
@version == other.version and
|
|
@platform == other.platform and
|
|
@dependencies == other.dependencies
|
|
end
|
|
|
|
def fetch_development_dependencies # :nodoc:
|
|
spec = source.fetch_spec Gem::NameTuple.new @name, @version, @platform
|
|
|
|
@dependencies = spec.dependencies
|
|
end
|
|
|
|
def installable_platform? # :nodoc:
|
|
Gem::Platform.match @platform
|
|
end
|
|
|
|
def pretty_print(q) # :nodoc:
|
|
q.group 2, '[APISpecification', ']' do
|
|
q.breakable
|
|
q.text "name: #{name}"
|
|
|
|
q.breakable
|
|
q.text "version: #{version}"
|
|
|
|
q.breakable
|
|
q.text "platform: #{platform}"
|
|
|
|
q.breakable
|
|
q.text 'dependencies:'
|
|
q.breakable
|
|
q.pp @dependencies
|
|
|
|
q.breakable
|
|
q.text "set uri: #{@set.dep_uri}"
|
|
end
|
|
end
|
|
|
|
##
|
|
# Fetches a Gem::Specification for this APISpecification.
|
|
|
|
def spec # :nodoc:
|
|
@spec ||=
|
|
begin
|
|
tuple = Gem::NameTuple.new @name, @version, @platform
|
|
source.fetch_spec tuple
|
|
rescue Gem::RemoteFetcher::FetchError
|
|
raise if @original_platform == @platform
|
|
|
|
tuple = Gem::NameTuple.new @name, @version, @original_platform
|
|
source.fetch_spec tuple
|
|
end
|
|
end
|
|
|
|
def source # :nodoc:
|
|
@set.source
|
|
end
|
|
end
|